chore: remove deprecation (api-platform#6508)

Author: soyuka

phpunit.baseline.xml

@@ -1,10 +1,5 @@
 <?xml version="1.0"?>
 <files version="1">
- <file path="src/GraphQl/Type/SchemaBuilder.php">
-  <line number="38" hash="7d00ace41a693456ebf14737d43e79ae5f77c386">
-   <issue><![CDATA[$fieldsBuilder argument of SchemaBuilder implementing "ApiPlatform\GraphQl\Type\FieldsBuilderInterface" is deprecated since API Platform 3.1. It has to implement "ApiPlatform\GraphQl\Type\FieldsBuilderEnumInterface" instead.]]></issue>
-  </line>
- </file>
  <file path="vendor/symfony/deprecation-contracts/function.php">
   <line number="25" hash="c6af5d66288d0667e424978000f29571e4954b81">
    <issue><![CDATA[Since symfony/validator 7.1: Not passing a value for the "requireTld" option to the Url constraint is deprecated. Its default value will change to "true".]]></issue>

src/GraphQl/Type/FieldsBuilder.php

@@ -47,7 +47,7 @@
  *
  * @author Alan Poulain <[email protected]>
  */
-final class FieldsBuilder implements FieldsBuilderInterface, FieldsBuilderEnumInterface
+final class FieldsBuilder implements FieldsBuilderEnumInterface
 {
     private readonly ContextAwareTypeBuilderInterface $typeBuilder;
 

src/GraphQl/Type/FieldsBuilderInterface.php

@@ -32,11 +32,8 @@
  */
 final class SchemaBuilder implements SchemaBuilderInterface
 {
-    public function __construct(private readonly ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory, private readonly ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, private readonly TypesFactoryInterface $typesFactory, private readonly TypesContainerInterface $typesContainer, private readonly FieldsBuilderEnumInterface|FieldsBuilderInterface $fieldsBuilder)
+    public function __construct(private readonly ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory, private readonly ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, private readonly TypesFactoryInterface $typesFactory, private readonly TypesContainerInterface $typesContainer, private readonly FieldsBuilderEnumInterface $fieldsBuilder)
     {
-        if ($this->fieldsBuilder instanceof FieldsBuilderInterface) {
-            @trigger_error(\sprintf('$fieldsBuilder argument of SchemaBuilder implementing "%s" is deprecated since API Platform 3.1. It has to implement "%s" instead.', FieldsBuilderInterface::class, FieldsBuilderEnumInterface::class), \E_USER_DEPRECATED);
-        }
     }
 
     public function getSchema(): Schema

src/GraphQl/Type/SchemaBuilder.php

@@ -195,15 +195,10 @@ public function getEnumType(Operation $operation): GraphQLType
             return $this->typesContainer->get($enumName);
         }
 
-        /** @var FieldsBuilderEnumInterface|FieldsBuilderInterface $fieldsBuilder */
+        /** @var FieldsBuilderEnumInterface $fieldsBuilder */
         $fieldsBuilder = $this->fieldsBuilderLocator->get('api_platform.graphql.fields_builder');
         $enumCases = [];
-        // Remove the condition in API Platform 4.
-        if ($fieldsBuilder instanceof FieldsBuilderEnumInterface) {
-            $enumCases = $fieldsBuilder->getEnumFields($operation->getClass());
-        } else {
-            @trigger_error(\sprintf('api_platform.graphql.fields_builder service implementing "%s" is deprecated since API Platform 3.1. It has to implement "%s" instead.', FieldsBuilderInterface::class, FieldsBuilderEnumInterface::class), \E_USER_DEPRECATED);
-        }
+        $enumCases = $fieldsBuilder->getEnumFields($operation->getClass());
 
         $enumConfig = [
             'name' => $enumName,