chore: remove goerli from all codebase (#1304)

bowenli86 · web-flow · commit f0ff053ed92c · 2025-04-04T09:24:35.000-07:00
**Motivation:**

goerli has long been gone, we should remove goerli from all codebase

**Modifications:**

remove goerli from all codebase

**Result:**

remove goerli from all codebase
diff --git a/README.md b/README.md
@@ -62,7 +62,7 @@ We have a few fork tests against ETH mainnet. Passing these requires the environ
 
 Additionally, to run all tests in a forked environment, [install yq](https://mikefarah.gitbook.io/yq/v/v3.x/). Then, set up your environment by running the following command.
 
-`source bin/source-env.sh [goerli|local]`
+`source bin/source-env.sh [local]`
 
 Then run the tests:
 
diff --git a/bin/source-env.sh b/bin/source-env.sh
@@ -2,22 +2,17 @@
 
 # Check for arguments
 if [ "$#" -ne 1 ]; then
-    echo "Usage: $0 [goerli|local]"
+    echo "Usage: $0 [local]"
     return 1
 fi
 
 case $1 in
-    goerli)
-        CHAIN_ID=5
-        EXECUTOR_MULTISIG="0x3d9C2c2B40d890ad53E27947402e977155CD2808"
-        FOUNDRY_FUZZ_RUNS=1
-        ;;
     local)
         CHAIN_ID=31337
         FOUNDRY_FUZZ_RUNS=256
         ;;
     *)
-        echo "Invalid argument. Usage: $0 [goerli|local]"
+        echo "Invalid argument. Usage: $0 [local]"
         return 1
         ;;
 esac
diff --git a/script/deploy/devnet/deploy_from_scratch.s.sol b/script/deploy/devnet/deploy_from_scratch.s.sol
@@ -443,7 +443,6 @@ contract DeployFromScratch is Script, Test {
         vm.serializeString(parent_object, chain_info, chain_info_output);
         string memory finalJson = vm.serializeString(parent_object, parameters, parameters_output);
         // TODO: should output to different file depending on configFile passed to run()
-        //       so that we don't override mainnet output by deploying to goerli for eg.
         vm.writeJson(finalJson, "script/output/devnet/slashing_output.json");
     }
 
diff --git a/script/utils/validateStorage/README.md b/script/utils/validateStorage/README.md
@@ -7,7 +7,7 @@ To validate the storage of an upgradeable deployed contract against a local one,
 bash script/upgrade/validateUpgrade.sh -n <network> -c <contract> -a <implementation address>
 ```
 
-The supported networks are `goerli` and `mainnet`. The supported contracts are `strategyManager`, `delegation`, `eigenPod`, `eigenPodManager`, and `slasher`.
+The supported networks are `mainnet`. The supported contracts are `strategyManager`, `delegation`, `eigenPod`, `eigenPodManager`, and `slasher`.
 
 The above script generates two csv files, `localLayout.csv` and `onChainLayout.csv`. To keep these csv files after validating storage, add a `-k` flag to the above command
 
diff --git a/script/utils/validateStorage/validateUpgrade.sh b/script/utils/validateStorage/validateUpgrade.sh
@@ -19,8 +19,8 @@ if [ -z "$NETWORK" ] || [ -z "$CONTRACT" ] || [ -z "$ADDRESS" ]; then
 fi
 
 # Validate the network input
-if [ "$NETWORK" != "mainnet" ] && [ "$NETWORK" != "goerli" ]; then
-  echo "Invalid network. Use 'mainnet' or 'goerli'."
+if [ "$NETWORK" != "mainnet" ] ; then
+  echo "Invalid network. Use 'mainnet'."
   exit 1
 fi
 
@@ -38,9 +38,7 @@ case $CONTRACT in
 esac
 
 # Set RPC
-if [ "$NETWORK" == "goerli" ]; then
-    RPC_URL="$RPC_GOERLI"
-else
+if [ "$NETWORK" == "mainnet" ]; then
     RPC_URL="$RPC_MAINNET"
 fi
 
diff --git a/src/test/unit/StrategyManagerUnit.t.sol b/src/test/unit/StrategyManagerUnit.t.sol
@@ -308,320 +308,6 @@ contract StrategyManagerUnitTests_depositIntoStrategy is StrategyManagerUnitTest
         testFuzz_depositIntoStrategySuccessfully(staker, amount);
     }
 
-    // TODO: test depositing into multiple strategies
-    // function testFuzz_depositIntoStrategy_MultipleStrategies()
-    // /// @notice deploys 'numStratsToAdd' strategies using '_testAddStrategy' and then deposits '1e18' to each of them from 'getOperatorAddress(0)'
-    // /// @param numStratsToAdd is the number of strategies being added and deposited into
-    // function testDepositStrategies(uint8 numStratsToAdd) public {
-    //     _testDepositStrategies(getOperatorAddress(0), 1e18, numStratsToAdd);
-    // }
-
-    // TODO: fix old stETH fork test
-    //     /// @notice Shadow-forks mainnet and tests depositing stETH tokens into a "StrategyBase" contract.
-    // function testForkMainnetDepositSteth() public {
-    //     // hard-coded inputs
-    //     // address sender = address(this);
-    //     uint64 amountToDeposit = 1e12;
-
-    //     // shadow-fork mainnet
-    //     try cheats.createFork("mainnet") returns (uint256 forkId) {
-    //         cheats.selectFork(forkId);
-    //     // If RPC_MAINNET ENV not set, default to this mainnet RPC endpoint
-    //     } catch  {
-    //         cheats.createSelectFork("https://eth.llamarpc.com");
-    //     }
-
-    //     // cast mainnet stETH address to IERC20 interface
-    //     // IERC20 steth = IERC20(0xae7ab96520DE3A18E5e111B5EaAb095312D7fE84);
-    //     IERC20 underlyingToken = IERC20(0xae7ab96520DE3A18E5e111B5EaAb095312D7fE84);
-
-    //     // deploy necessary contracts on the shadow-forked network
-    //     // deploy proxy admin for ability to upgrade proxy contracts
-    //     eigenLayerProxyAdmin = new ProxyAdmin();
-    //     //deploy pauser registry
-    //     address[] memory pausers = new address[](1);
-    //     pausers[0] = pauser;
-    //     eigenLayerPauserReg = new PauserRegistry(pausers, unpauser);
-    //     /**
-    //      * First, deploy upgradeable proxy contracts that **will point** to the implementations. Since the implementation contracts are
-    //      * not yet deployed, we give these proxies an empty contract as the initial implementation, to act as if they have no code.
-    //      */
-    //     emptyContract = new EmptyContract();
-    //     delegation = DelegationManager(
-    //         address(new TransparentUpgradeableProxy(address(emptyContract), address(eigenLayerProxyAdmin), ""))
-    //     );
-    //     strategyManager = StrategyManager(
-    //         address(new TransparentUpgradeableProxy(address(emptyContract), address(eigenLayerProxyAdmin), ""))
-    //     );
-    //     eigenPodManager = EigenPodManager(
-    //         address(new TransparentUpgradeableProxy(address(emptyContract), address(eigenLayerProxyAdmin), ""))
-    //     );
-
-    //     ethPOSDeposit = new ETHPOSDepositMock();
-    //     pod = new EigenPod(ethPOSDeposit, eigenPodManager, GOERLI_GENESIS_TIME);
-
-    //     eigenPodBeacon = new UpgradeableBeacon(address(pod));
-    //     // Second, deploy the *implementation* contracts, using the *proxy contracts* as inputs
-    //     DelegationManager delegationImplementation = new DelegationManager(avsDirectory, strategyManager, eigenPodManager, allocationManager, MIN_WITHDRAWAL_DELAY);
-    //     StrategyManager strategyManagerImplementation = new StrategyManager(delegation);
-    //     EigenPodManager eigenPodManagerImplementation = new EigenPodManager(ethPOSDeposit, eigenPodBeacon, strategyManager, delegation);
-    //     // Third, upgrade the proxy contracts to use the correct implementation contracts and initialize them.
-    //     eigenLayerProxyAdmin.upgradeAndCall(
-    //         ITransparentUpgradeableProxy(payable(address(delegation))),
-    //         address(delegationImplementation),
-    //         abi.encodeWithSelector(
-    //             DelegationManager.initialize.selector,
-    //             eigenLayerReputedMultisig,
-    //             eigenLayerPauserReg,
-    //             0 /*initialPausedStatus*/,
-    //             minWithdrawalDelayBlocks,
-    //             initializeStrategiesToSetDelayBlocks,
-    //             initializeWithdrawalDelayBlocks
-    //         )
-    //     );
-    //     eigenLayerProxyAdmin.upgradeAndCall(
-    //         ITransparentUpgradeableProxy(payable(address(strategyManager))),
-    //         address(strategyManagerImplementation),
-    //         abi.encodeWithSelector(
-    //             StrategyManager.initialize.selector,
-    //             eigenLayerReputedMultisig,
-    //             eigenLayerReputedMultisig,
-    //             eigenLayerPauserReg,
-    //             0/*initialPausedStatus*/
-    //         )
-    //     );
-    //     eigenLayerProxyAdmin.upgradeAndCall(
-    //         ITransparentUpgradeableProxy(payable(address(eigenPodManager))),
-    //         address(eigenPodManagerImplementation),
-    //         abi.encodeWithSelector(
-    //             EigenPodManager.initialize.selector,
-    //             eigenLayerReputedMultisig,
-    //             eigenLayerPauserReg,
-    //             0/*initialPausedStatus*/
-    //         )
-    //     );
-
-    //     // cheat a bunch of ETH to this address
-    //     cheats.deal(address(this), 1e20);
-    //     // deposit a huge amount of ETH to get ample stETH
-    //     {
-    //         (bool success, bytes memory returnData) = address(underlyingToken).call{value: 1e20}("");
-    //         require(success, "depositing stETH failed");
-    //         returnData;
-    //     }
-
-    //     // deploy StrategyBase contract implementation, then create upgradeable proxy that points to implementation and initialize it
-    //     baseStrategyImplementation = new StrategyBase(strategyManager);
-    //     IStrategy stethStrategy = StrategyBase(
-    //             address(
-    //                 new TransparentUpgradeableProxy(
-    //                     address(baseStrategyImplementation),
-    //                     address(eigenLayerProxyAdmin),
-    //                 abi.encodeWithSelector(StrategyBase.initialize.selector, underlyingToken, eigenLayerPauserReg)
-    //                 )
-    //             )
-    //         );
-
-    //     // REMAINDER OF CODE ADAPTED FROM `_testDepositToStrategy`
-    //     // _testDepositToStrategy(sender, amountToDeposit, underlyingToken, stethStrategy);
-
-    //     // whitelist the strategy for deposit, in case it wasn't before
-    //     {
-    //         cheats.startPrank(strategyManager.strategyWhitelister());
-    //         IStrategy[] memory _strategy = new IStrategy[](1);
-    //         _strategy[0] = stethStrategy;
-    //         strategyManager.addStrategiesToDepositWhitelist(_strategy);
-    //         cheats.stopPrank();
-    //     }
-
-    //     uint256 operatorSharesBefore = strategyManager.stakerDepositShares(address(this), stethStrategy);
-    //     // check the expected output
-    //     uint256 expectedSharesOut = stethStrategy.underlyingToShares(amountToDeposit);
-
-    //     underlyingToken.transfer(address(this), amountToDeposit);
-    //     cheats.startPrank(address(this));
-    //     underlyingToken.approve(address(strategyManager), type(uint256).max);
-    //     strategyManager.depositIntoStrategy(stethStrategy, underlyingToken, amountToDeposit);
-
-    //     //check if depositor has never used this strat, that it is added correctly to stakerStrategyList array.
-    //     if (operatorSharesBefore == 0) {
-    //         // check that strategy is appropriately added to dynamic array of all of sender's strategies
-    //         assertTrue(
-    //             strategyManager.stakerStrategyList(address(this), strategyManager.stakerStrategyListLength(address(this)) - 1)
-    //                 == stethStrategy,
-    //             "_testDepositToStrategy: stakerStrategyList array updated incorrectly"
-    //         );
-    //     }
-    //     // check that the shares out match the expected amount out
-    //     // the actual transfer in will be lower by 1-2 wei than expected due to stETH's internal rounding
-    //     // to account for this we check approximate rather than strict equivalence here
-    //     {
-    //         uint256 actualSharesOut = strategyManager.stakerDepositShares(address(this), stethStrategy) - operatorSharesBefore;
-    //         require(actualSharesOut >= expectedSharesOut, "too few shares");
-    //         require((actualSharesOut * 1000) / expectedSharesOut < 1003, "too many shares");
-
-    //         // additional sanity check for deposit not increasing in value
-    //         require(stethStrategy.sharesToUnderlying(actualSharesOut) <= amountToDeposit, "value cannot have increased");
-    //         // slippage check
-    //         require((stethStrategy.sharesToUnderlying(actualSharesOut) * 1e6) / amountToDeposit >= (1e6 - 1), "bad slippage on first deposit");
-    //     }
-    //     cheats.stopPrank();
-    // }
-
-    // TODO: fix old frontrun depositor test
-    // function testFrontrunFirstDepositor(/*uint256 depositAmount*/) public {
-
-    //     //setup addresses
-    //     address attacker = address(100);
-    //     address user = address(200);
-
-    //     //give 2 ether to attacker and user
-    //     weth.transfer(attacker,2 ether);
-    //     weth.transfer(user,2 ether);
-
-    //     //attacker FRONTRUN: deposit 1 wei (receive 1 share)
-    //     StrategyManager _strategyManager = _whitelistStrategy(strategyManager, wethStrat);
-
-    //     cheats.startPrank(attacker);
-    //     weth.approve(address(strategyManager), type(uint256).max);
-    //     _strategyManager.depositIntoStrategy(wethStrat, weth, 1 wei);
-    //     cheats.stopPrank();
-
-    //     //attacker FRONTRUN: transfer 1 ether into strategy directly to manipulate the value of shares
-    //     cheats.prank(attacker);
-    //     weth.transfer(address(wethStrat),1 ether);
-
-    //     //user deposits 2 eth into strategy - only gets 1 share due to rounding
-    //     cheats.startPrank(user);
-    //     weth.approve(address(_strategyManager), type(uint256).max);
-    //     _strategyManager.depositIntoStrategy(wethStrat, weth, 2 ether);
-    //     cheats.stopPrank();
-
-    //     //attacker deposited 1 ether and 1 wei - received 1 share
-    //     //user deposited 2 ether - received X shares
-    //     //user has lost 0.5 ether?
-    //     (, uint256[] memory shares) = _strategyManager.getDeposits(attacker);
-    //     uint256 attackerValueWeth = wethStrat.sharesToUnderlyingView(shares[0]);
-    //     require(attackerValueWeth >= (1), "attacker got zero shares");
-
-    //     (, shares) = _strategyManager.getDeposits(user);
-    //     uint256 userValueWeth = wethStrat.sharesToUnderlyingView(shares[0]);
-    //     require(userValueWeth >= (1900000000000000000), "user has lost more than 0.1 eth from frontrunning");
-
-    //     uint256 attackerLossesWeth = (2 ether + 1 wei) - attackerValueWeth;
-    //     uint256 userLossesWeth = 2 ether - userValueWeth;
-    //     require(attackerLossesWeth > userLossesWeth, "griefing attack deals more damage than cost");
-    // }
-
-    // TODO: fix old testFrontrunFirstDepositorFuzzed
-    // function testFrontrunFirstDepositorFuzzed(uint96 firstDepositAmount, uint96 donationAmount, uint96 secondDepositAmount) public {
-    //     // want to only use nonzero amounts or else we'll get reverts
-    //     cheats.assume(firstDepositAmount != 0 && secondDepositAmount != 0);
-
-    //     // setup addresses
-    //     address attacker = address(100);
-    //     address user = address(200);
-
-    //     // attacker makes first deposit
-    //     _testDepositToStrategy(attacker, firstDepositAmount, weth, wethStrat);
-
-    //     // transfer tokens into strategy directly to manipulate the value of shares
-    //     weth.transfer(address(wethStrat), donationAmount);
-
-    //     // filter out calls that would revert for minting zero shares
-    //     cheats.assume(wethStrat.underlyingToShares(secondDepositAmount) != 0);
-
-    //     // user makes 2nd deposit into strategy - gets diminished shares due to rounding
-    //     _testDepositToStrategy(user, secondDepositAmount, weth, wethStrat);
-
-    //     // check for griefing
-    //     (, uint256[] memory shares) = strategyManager.getDeposits(attacker);
-    //     uint256 attackerValueWeth = wethStrat.sharesToUnderlyingView(shares[0]);
-    //     (, shares) = strategyManager.getDeposits(user);
-    //     uint256 userValueWeth = wethStrat.sharesToUnderlyingView(shares[0]);
-
-    //     uint256 attackerCost = uint256(firstDepositAmount) + uint256(donationAmount);
-    //     require(attackerCost >= attackerValueWeth, "attacker gained value?");
-    //     // uint256 attackerLossesWeth = attackerValueWeth > attackerCost ? 0 : (attackerCost - attackerValueWeth);
-    //     uint256 attackerLossesWeth = attackerCost - attackerValueWeth;
-    //     uint256 userLossesWeth = secondDepositAmount - userValueWeth;
-
-    //     emit log_named_uint("attackerLossesWeth", attackerLossesWeth);
-    //     emit log_named_uint("userLossesWeth", userLossesWeth);
-
-    //     // use '+1' here to account for rounding. given the attack will cost ETH in the form of gas, this is fine.
-    //     require(attackerLossesWeth + 1 >= userLossesWeth, "griefing attack deals more damage than cost");
-    // }
-
-    // TODO: testDepositTokenWithOneWeiFeeOnTransfer
-    // function testDepositTokenWithOneWeiFeeOnTransfer(address sender, uint64 amountToDeposit) public fuzzedAddress(sender) {
-    //     cheats.assume(amountToDeposit != 0);
-
-    //     IERC20 underlyingToken;
-
-    //     {
-    //         uint256 initSupply = 1e50;
-    //         address initOwner = address(this);
-    //         ERC20_OneWeiFeeOnTransfer oneWeiFeeOnTransferToken = new ERC20_OneWeiFeeOnTransfer(initSupply, initOwner);
-    //         underlyingToken = IERC20(address(oneWeiFeeOnTransferToken));
-    //     }
-
-    //     // need to transfer extra here because otherwise the `sender` won't have enough tokens
-    //     underlyingToken.transfer(sender, 1000);
-
-    //     IStrategy oneWeiFeeOnTransferTokenStrategy = StrategyBase(
-    //             address(
-    //                 new TransparentUpgradeableProxy(
-    //                     address(baseStrategyImplementation),
-    //                     address(eigenLayerProxyAdmin),
-    //                 abi.encodeWithSelector(StrategyBase.initialize.selector, underlyingToken, eigenLayerPauserReg)
-    //                 )
-    //             )
-    //         );
-
-    //     // REMAINDER OF CODE ADAPTED FROM `_testDepositToStrategy`
-    //     // _testDepositToStrategy(sender, amountToDeposit, underlyingToken, oneWeiFeeOnTransferTokenStrategy);
-
-    //     // whitelist the strategy for deposit, in case it wasn't before
-    //     {
-    //         cheats.startPrank(strategyManager.strategyWhitelister());
-    //         IStrategy[] memory _strategy = new IStrategy[](1);
-    //         _strategy[0] = oneWeiFeeOnTransferTokenStrategy;
-    //         strategyManager.addStrategiesToDepositWhitelist(_strategy);
-    //         cheats.stopPrank();
-    //     }
-    //     uint256 operatorSharesBefore = strategyManager.stakerDepositShares(sender, oneWeiFeeOnTransferTokenStrategy);
-    //     // check the expected output
-    //     uint256 expectedSharesOut = oneWeiFeeOnTransferTokenStrategy.underlyingToShares(amountToDeposit);
-
-    //     underlyingToken.transfer(sender, amountToDeposit);
-    //     cheats.startPrank(sender);
-    //     underlyingToken.approve(address(strategyManager), type(uint256).max);
-    //     strategyManager.depositIntoStrategy(oneWeiFeeOnTransferTokenStrategy, underlyingToken, amountToDeposit);
-
-    //     //check if depositor has never used this strat, that it is added correctly to stakerStrategyList array.
-    //     if (operatorSharesBefore == 0) {
-    //         // check that strategy is appropriately added to dynamic array of all of sender's strategies
-    //         assertTrue(
-    //             strategyManager.stakerStrategyList(sender, strategyManager.stakerStrategyListLength(sender) - 1)
-    //                 == oneWeiFeeOnTransferTokenStrategy,
-    //             "_testDepositToStrategy: stakerStrategyList array updated incorrectly"
-    //         );
-    //     }
-    //     // check that the shares out match the expected amount out
-    //     // the actual transfer in will be lower by 1 wei than expected due to stETH's internal rounding
-    //     // to account for this we check approximate rather than strict equivalence here
-    //     {
-    //         uint256 actualSharesOut = strategyManager.stakerDepositShares(sender, oneWeiFeeOnTransferTokenStrategy) - operatorSharesBefore;
-    //         require((actualSharesOut * 1000) / expectedSharesOut > 998, "too few shares");
-    //         require((actualSharesOut * 1000) / expectedSharesOut < 1002, "too many shares");
-
-    //         // additional sanity check for deposit not increasing in value
-    //         require(oneWeiFeeOnTransferTokenStrategy.sharesToUnderlying(actualSharesOut) <= amountToDeposit, "value cannot have increased");
-    //     }
-    //     cheats.stopPrank();
-    // }
-
     function test_Revert_WhenDepositsPaused() public {
         uint amount = 1e18;
 

Original file line number	Diff line number	Diff line change
`@@ -443,7 +443,6 @@ contract DeployFromScratch is Script, Test {`
`443`	`443`	`vm.serializeString(parent_object, chain_info, chain_info_output);`
`444`	`444`	`string memory finalJson = vm.serializeString(parent_object, parameters, parameters_output);`
`445`	`445`	`// TODO: should output to different file depending on configFile passed to run()`
`446`		`- // so that we don't override mainnet output by deploying to goerli for eg.`
`447`	`446`	`vm.writeJson(finalJson, "script/output/devnet/slashing_output.json");`
`448`	`447`	`}`
`449`	`448`