chore: fix tests

Author: ypatil12

src/test/integration/IntegrationBase.t.sol

@@ -1216,7 +1216,7 @@ abstract contract IntegrationBase is IntegrationDeployer, TypeImporter {
         uint wadToSlash = slashingParams.wadsToSlash[0];
         slashedShares = prevShares.mulWadRoundUp(allocateParams.newMagnitudes[0].mulWadRoundUp(wadToSlash));
 
-        assertEq(prevShares - slashedShares, curShares, err);
+        assertApproxEqAbs(prevShares - slashedShares, curShares, 1e2, err);
     }
 
     /// @dev Validates behavior of "restaking", ie. that the funds can be slashed twice
@@ -1234,29 +1234,35 @@ abstract contract IntegrationBase is IntegrationDeployer, TypeImporter {
         uint prevShares = _getPrevWithdrawableShares(staker, allocateParams.strategies)[0];
         uint depositShares = _getStakerDepositShares(staker, allocateParams.strategies)[0];
 
-        // 1. The withdrawable shares should decrease by a factor of the BCSF
-        assertEq(prevShares.mulWad(_getBeaconChainSlashingFactor(staker)), curShares, err);
-
-        // /**
-        //  * 2. The delta in shares is given by:
-        //  * (depositShares * operatorMag) - (depositShares * operatorMag * BCSF)
-        //  *  = depositShares * operatorMag * (1 - BCSF)
-        //  */
-        // uint beaconChainSlashingFactor = _getBeaconChainSlashingFactor(staker);
-        // uint wadToSlash = slashingParams.wadsToSlash[0];
-        // uint originalAVSSlashedShares = depositShares.mulWadRoundUp(allocateParams.newMagnitudes[0].mulWadRoundUp(wadToSlash));
-        // uint withdrawableSharesAfterAVSSlash = depositShares - originalAVSSlashedShares;
-        // uint expectedDelta = withdrawableSharesAfterAVSSlash.mulWad(WAD - beaconChainSlashingFactor);
-        // assertEq(prevShares - expectedDelta, curShares, err);
-
-        // /**
-        //  * 3. The attributable avs slashed shares should decrease by a factor of the BCSF
-        //  * Attributable avs slashed shares = originalWithdrawableShares - bcSlashedShares - curShares
-        //  * Where bcSlashedShares = originalWithdrawableShares * (1 - BCSF)
-        //  */
-        // uint bcSlashedShares = depositShares.mulWad(WAD - beaconChainSlashingFactor);
-        // uint attributableAVSSlashedShares = depositShares - bcSlashedShares - curShares;
-        // assertEq(originalAVSSlashedShares.mulWad(beaconChainSlashingFactor), attributableAVSSlashedShares, err);
+        // 1. The slashing factor and withdrawable shares should decrease by a factor of the BCSF
+        // We use assertApproxEq on shares since intermediate division on calculation of slashing factor introduces some additional rounding error
+        uint slashingFactor = _getSlashingFactor(staker, allocateParams.strategies[0]);
+        uint prevSlashingFactor = _getPrevSlashingFactor(staker, allocateParams.strategies[0]);
+        assertEq(prevSlashingFactor.mulWad(_getBeaconChainSlashingFactor(staker)), slashingFactor, err);
+        assertApproxEqAbs(prevShares.mulWad(_getBeaconChainSlashingFactor(staker)), curShares, 1e2, err);
+
+        /**
+         * 2. The delta in shares is given by:
+         * (depositShares * operatorMag) - (depositShares * operatorMag * BCSF)
+         *  = depositShares * operatorMag * (1 - BCSF)
+         */
+        uint beaconChainSlashingFactor = _getBeaconChainSlashingFactor(staker);
+        uint wadToSlash = slashingParams.wadsToSlash[0];
+        uint originalAVSSlashedShares = depositShares.mulWadRoundUp(allocateParams.newMagnitudes[0].mulWadRoundUp(wadToSlash));
+        {
+            uint withdrawableSharesAfterAVSSlash = depositShares - originalAVSSlashedShares;
+            uint expectedDelta = withdrawableSharesAfterAVSSlash.mulWad(WAD - beaconChainSlashingFactor);
+            assertApproxEqAbs(prevShares - expectedDelta, curShares, 1e2, err);
+        }
+
+        /**
+         * 3. The attributable avs slashed shares should decrease by a factor of the BCSF
+         * Attributable avs slashed shares = originalWithdrawableShares - bcSlashedShares - curShares
+         * Where bcSlashedShares = originalWithdrawableShares * (1 - BCSF)
+         */
+        uint bcSlashedShares = depositShares.mulWad(WAD - beaconChainSlashingFactor);
+        uint attributableAVSSlashedShares = depositShares - bcSlashedShares - curShares;
+        assertApproxEqAbs(originalAVSSlashedShares.mulWad(beaconChainSlashingFactor), attributableAVSSlashedShares, 1e2, err);
     }
 
     /**

src/test/integration/tests/DualSlashing.t.sol

@@ -188,19 +188,19 @@ contract Integration_DualSlashing_AVSFirst is Integration_DualSlashing_Base {
             staker, validators, initDepositShares[0], slashedAmountGwei, allocateParams, slashingParams
         );
 
-        // // 9. Verify Validator
-        // cheats.deal(address(staker), 32 ether);
-        // (uint40[] memory newValidators, uint64 addedBeaconBalanceGwei,) = staker.startValidators();
-        // uint beaconSharesAdded = uint(addedBeaconBalanceGwei * GWEI_TO_WEI);
-        // beaconChain.advanceEpoch_NoRewards();
-        // staker.verifyWithdrawalCredentials(newValidators);
-        // check_VerifyWC_State(staker, newValidators, addedBeaconBalanceGwei);
-        // assert_Snap_Added_Staker_WithdrawableShares_AtLeast(
-        //     staker,
-        //     BEACONCHAIN_ETH_STRAT.toArray(),
-        //     beaconSharesAdded.toArrayU256(),
-        //     "staker withdrawable shares should increase by the added beacon balance"
-        // );
+        // 9. Verify Validator
+        cheats.deal(address(staker), 32 ether);
+        (uint40[] memory newValidators, uint64 addedBeaconBalanceGwei,) = staker.startValidators();
+        uint beaconSharesAdded = uint(addedBeaconBalanceGwei * GWEI_TO_WEI);
+        beaconChain.advanceEpoch_NoRewards();
+        staker.verifyWithdrawalCredentials(newValidators);
+        check_VerifyWC_State(staker, newValidators, addedBeaconBalanceGwei);
+        assert_Snap_Added_Staker_WithdrawableShares_AtLeast(
+            staker,
+            BEACONCHAIN_ETH_STRAT.toArray(),
+            beaconSharesAdded.toArrayU256(),
+            "staker withdrawable shares should increase by the added beacon balance"
+        );
     }
 
     /// @notice The balance increase results in the pods not processing the beacon slash as a slash, given