Skip to content

Commit 3051208

Browse files
committedMar 20, 2025·
fix: Fork diff action - fix CI and update summaries
1 parent 8f04f87 commit 3051208

File tree

3 files changed

+30
-26
lines changed

3 files changed

+30
-26
lines changed
 

‎.github/workflows/pages.yml

+8-7
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Checkout
1919
uses: actions/checkout@v3
2020
with:
21-
fetch-depth: 1000 # make sure to fetch the old commit we diff against
21+
fetch-depth: 1000 # Ensure history is fetched for Forkdiff comparison
2222

2323
- name: Build forkdiff
2424
uses: "docker://protolambda/forkdiff:0.1.0"
@@ -28,14 +28,15 @@ jobs:
2828
- name: Setup Pages
2929
uses: actions/configure-pages@v5
3030

31-
- name: Build with Jekyll
32-
uses: actions/jekyll-build-pages@v1.0.13
33-
with:
34-
source: ./
35-
destination: ./_site
31+
- name: Move index.html to _site
32+
run: |
33+
mkdir -p _site
34+
mv index.html _site/
3635
3736
- name: Upload artifact
3837
uses: actions/upload-pages-artifact@v3
38+
with:
39+
path: _site # Upload only the _site directory containing index.html
3940

4041
deploy:
4142
environment:
@@ -46,4 +47,4 @@ jobs:
4647
steps:
4748
- name: Deploy to GitHub Pages
4849
id: deployment
49-
uses: actions/deploy-pages@v4
50+
uses: actions/deploy-pages@v4

‎.gitignore

+3
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,6 @@ system_tests/test-data/*
2323
.configs/
2424
system_tests/testdata/*
2525
arbos/testdata/*
26+
27+
## fork diff
28+
index.html

‎fork.yaml

+19-19
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ footer: | # define the footer with markdown
55
base:
66
name: OffchainLabs/nitro
77
url: https://github.com/OffchainLabs/nitro
8-
hash: d81324daee7340281ee61c0f5db5231ec1d88eea
8+
hash: bdc2fd23dcf42b783c51e84acd3b01a973b78a34
99
fork:
1010
name: Layr-Labs/nitro
1111
url: https://github.com/Layr-Labs/nitro
@@ -40,6 +40,7 @@ def:
4040
globs:
4141
- "Dockerfile"
4242
- ".github/workflows/docker-upload.yml"
43+
- ".github/actions/docker-image/action.yml"
4344
- "scripts/download-machine-eigenda.sh"
4445

4546
- title: "EigenDA package"
@@ -84,22 +85,22 @@ def:
8485
- "eigenda/serialize.go"
8586
- "eigenda/serialize_test.go"
8687

87-
88-
- title: "Certificate translations"
88+
- title: "EigenDA certificate"
8989
description: |
90-
Certificates read from the `SequencerInbox` don't include all necessary metadata for properly referencing the batch via proxy since
91-
some fields are left out during inbox submission (i.e, `batchHeaderHash`) to reduce calldata sizes. These functions provide translation
92-
to convert a certificate read from the inbox into one understood by the proxy service.
90+
Introduce a structured `EigenDAV1Cert` type which wraps [EigenDACertVerifier](https://github.com/Layr-Labs/eigenda/blob/d6339ebb7cd12ec7483fc5c31c1b12bc97d3401c/contracts/src/core/EigenDACertVerifier.sol)
91+
go binding types for seamless compatibility with `addSequencerL2BatchFromEigenDA` inbox method. Also provides transformation functions
92+
to convert into/from the `BlobStatusInfo` struct returned by eigenda-proxy.
9393
9494
globs:
95-
- "eigenda/types.go"
95+
- "eigenda/certificate.go"
9696

9797
- title: "Fraud Proving"
9898
sub:
9999
- title: "EigenDA preimage opcode"
100100
description: |
101101
Extended core interpreter logic to target EigenDA `READPREIMAGE` opcode when serializing machine state proofs.
102-
Also extended go -> wavm compilation logic to support routing for the new opcode type.
102+
Also extended wasm -> wavm transpilation logic to support routing into the new opcode type.
103+
103104
globs:
104105
- "arbitrator/arbutil/src/types.rs"
105106
- "arbitrator/jit/src/wavmio.rs"
@@ -137,16 +138,15 @@ def:
137138
- title: "E2E challenge tests"
138139
description: |
139140
Extended E2E challenge tests to ensure honest resolution of a `READINBOXMESSAGE` challenge for an
140-
EigenDA certificate where each validator has alternative views of the canonical sequencer inbox state.
141+
EigenDA certificate where each validator has alternative views of the sequencer inbox state.
141142
globs:
142143
- "system_tests/full_challenge_test.go"
143144
- "system_tests/full_challenge_mock_test.go"
144145
- "system_tests/full_challenge_impl_test.go"
145146

146-
- title: "Batch posting & derivation from EigenDA"
147+
- title: "Batch posting & derivation via EigenDA"
147148
description: |
148-
Added the ability to post batches to EigenDA and trustlessly derive them using the respective
149-
certificate posted via the parent chain `SequencerInbox` contract.
149+
Added the ability to post batches to EigenDA and derive them from the inbox.
150150
sub:
151151
- title: "Config Ingestion"
152152
description: |
@@ -167,16 +167,15 @@ def:
167167

168168
- title: "Inbox Reading (Batch Derivation)"
169169
description: |
170-
Added EigenDA-specific batch posting logic to the Arbitrum Nitro batch poster. This includes utilizing the
171-
new `addSequencerL2BatchFromEigenDA` entrypoint in the `SequencerInbox` contract for submitting certificate txs
172-
as well as an optional `failover` mechanism for automatic fallback to native Arbitrum DA (i.e, AnyTrust, 4844, calldata)
173-
in the event of EigenDA service unavailability.
170+
Transforms a sequencer inbox transaction to extract the inputted rlp encoded EigenDA certificate that was check-pointed
171+
against the onchain accumulator.
174172
globs:
175173
- "arbnode/sequencer_inbox.go"
176-
-
177174

178175
- title: "Integration Tests"
179-
description:
176+
description: |
177+
Added tests to assert the correctness batch posting/derivation when using EigenDA. Also test failover circumstances to ensure
178+
batch poster can fallback to native Arbitrum DA with no impacts to safe/final head syncing.
180179
globs:
181180
- "system_tests/eigenda_test.go"
182181

@@ -197,4 +196,5 @@ ignore:
197196
- "arbnode/inbox_tracker.go"
198197
- "arbitrator/prover/src/main.rs"
199198
- "arbitrator/jit/src/test.rs"
200-
- "validator/server_jit/jit_machine.go"
199+
- "validator/server_jit/jit_machine.go"
200+
- fork.yaml

0 commit comments

Comments
 (0)
Please sign in to comment.