This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Cleanup .gitignore and ignore built directory #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bmoduleInstallation Fix error on installing Harmony
Add name to config
Update readme with install instructions and usage
|
Looks like this has to be rebased before merging |
Change link harmony after install instead of before
|
Just did a rebase, but it also marks the files changed which were merged by you earlier. I suspect this won't cause an issue. If you want me to open a new PR just in case, let me know. |
|
It looks like the rebase wasn't done properly (due to the old commits also showing on this PR). Easiest way to fix this would probably be to re-do the changes in a clean branch and PR with that. Optionally I can squash merge, if that's too much work. |
|
I'll make a new clean PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #42