Skip to content

Commit

Permalink
[ci][fix] Falling back to explicit package build, test & publish rath…
Browse files Browse the repository at this point in the history
…er than using the reusable workflow
  • Loading branch information
lpascal-ledger committed Feb 7, 2024
1 parent 0836e42 commit 08077ff
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 12 deletions.
53 changes: 41 additions & 12 deletions .github/workflows/python-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ jobs:
steps:
- name: Clone
uses: actions/checkout@v3
- run: pip install flake8
- run: pip install flake8 flake8-pyproject
- name: Flake8 lint Python code
run: (cd client && find src/ -type f -name '*.py' -exec flake8 --max-line-length=120 '{}' '+')
run: (cd client && flake8 src/)

mypy:
name: Type checking
Expand All @@ -38,14 +38,43 @@ jobs:
- name: Mypy type checking
run: (cd client && mypy src/)

packaging:
package_and_deploy:
name: Build and deploy Ethereum Client Python package
runs-on: ubuntu-latest
needs: [lint, mypy]
name: Build, test and deploy the Python package
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_pypi_deployment.yml@v1
with:
package_directory: "client/"
stable_deployment: true
check_changelog_version: ${{ startsWith(github.ref,'refs/tags/') }}
publish: ${{ github.event_name == 'push' }}
secrets:
pypi_token: secrets.PYPI_PUBLIC_API_TOKEN
steps:

- name: Clone
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Build Python package
run: |
pip install --upgrade pip build twine
cd client/
python -m build;
python -m twine check dist/*
pip install .;
echo "TAG_VERSION=$(python -c 'from ledger_app_clients.ethereum import __version__; print(__version__)')" >> "$GITHUB_ENV"
- name: Check version against CHANGELOG
if: startsWith(github.ref, 'refs/tags/')
run: |
CHANGELOG_VERSION=$(grep -Po '(?<=## \[)(\d+\.)+[^\]]' client/CHANGELOG.md | head -n 1)
if [ "${{ env.TAG_VERSION }}" == "${CHANGELOG_VERSION}" ];
then
echo 'Package and CHANGELOG versions match!';
exit 0;
else
echo "Tag '${{ env.TAG_VERSION }}' and CHANGELOG '${CHANGELOG_VERSION}' versions mismatch!";
exit 1;
fi
- name: Publish Python package on pypi.org
if: success() && github.event_name == 'push'
run: (cd client && python -m twine upload --verbose dist/*)
env:
TWINE_USERNAME: __token__
TWINE_PASSWORD: ${{ secrets.PYPI_PUBLIC_API_TOKEN }}
TWINE_NON_INTERACTIVE: 1
3 changes: 3 additions & 0 deletions client/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,6 @@ Home = "https://github.com/LedgerHQ/app-ethereum"

[tool.mypy]
ignore_missing_imports = true

[tool.flake8]
max-line-length = 120

0 comments on commit 08077ff

Please sign in to comment.