Skip to content

Commit

Permalink
Adapt code for Nano devices on NBGL - No skip on Nano
Browse files Browse the repository at this point in the history
  • Loading branch information
cedelavergne-ledger committed Feb 21, 2025
1 parent 5e7cc08 commit 55d4184
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions src_nbgl/ui_sign_712.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ static size_t buf_idx;
static bool filtered;
static bool review_skipped;

nbgl_callback_t skip_callback = NULL;

static void message_progress(bool confirm) {
char *buf;
size_t buf_size;
Expand All @@ -38,10 +40,12 @@ static void message_progress(bool confirm) {
}
}

#ifdef SCREEN_SIZE_WALLET
static void review_skip(void) {
review_skipped = true;
message_progress(true);
}
#endif // SCREEN_SIZE_WALLET

static void message_update(bool confirm) {
char *buf;
Expand All @@ -65,7 +69,7 @@ static void message_update(bool confirm) {
nbgl_useCaseGetNbTagValuesInPageExt(pair_idx, &pairs_list, 0, !filtered, &flag);
}
if (!review_skipped && ((pair_idx == ARRAYLEN(pairs)) || (pairs_list.nbPairs < pair_idx))) {
nbgl_useCaseReviewStreamingContinueExt(&pairs_list, message_progress, review_skip);
nbgl_useCaseReviewStreamingContinueExt(&pairs_list, message_progress, skip_callback);
} else {
message_progress(true);
}
Expand All @@ -82,6 +86,9 @@ static void ui_712_start_common(bool has_filtering) {
buf_idx = 0;
filtered = has_filtering;
review_skipped = false;
#ifdef SCREEN_SIZE_WALLET
skip_callback = review_skip;
#endif // SCREEN_SIZE_WALLET
}

void ui_712_start_unfiltered(void) {
Expand Down Expand Up @@ -110,7 +117,7 @@ void ui_712_switch_to_sign(void) {
if (!review_skipped && (pair_idx > 0)) {
pairs_list.nbPairs = pair_idx;
pair_idx = 0;
nbgl_useCaseReviewStreamingContinueExt(&pairs_list, message_progress, review_skip);
nbgl_useCaseReviewStreamingContinueExt(&pairs_list, message_progress, skip_callback);
} else {
nbgl_useCaseReviewStreamingFinish(filtered ? TEXT_SIGN_EIP712 : TEXT_BLIND_SIGN_EIP712,
ui_typed_message_review_choice);
Expand Down

0 comments on commit 55d4184

Please sign in to comment.