Merge pull request #557 from LedgerHQ/cev/B2CA-1247_update-changelog

Update plugin_sdk changelog after B2CA-1247
LedgerHQ · Mar 27, 2024 · 831eee2 · 831eee2
2 parents 0787f27 + 1a8bb93
commit 831eee2
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 30 deletions.
diff --git a/Makefile b/Makefile
@@ -34,7 +34,7 @@ APP_LOAD_PARAMS += --path "1517992542'/1101353413'"
 
 APPVERSION_M = 1
 APPVERSION_N = 11
-APPVERSION_P = 1
+APPVERSION_P = 0
 APPVERSION = $(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)-dev
 APP_LOAD_FLAGS = --appFlags 0xa40 --dep Ethereum:$(APPVERSION)
 

diff --git a/src_common/common_utils.h b/src_common/common_utils.h
@@ -63,33 +63,6 @@ void getEthAddressStringFromRawKey(const uint8_t raw_pubkey[static 65],
                                    char out[static ADDRESS_LENGTH * 2],
                                    uint64_t chainId);
 
-/**
- * @deprecated
- * See #getEthAddressFromRawKey
- */
-DEPRECATED static inline bool getEthAddressFromKey(cx_ecfp_public_key_t *publicKey,
-                                                   uint8_t *out,
-                                                   cx_sha3_t *sha3Context) {
-    UNUSED(sha3Context);
-
-    getEthAddressFromRawKey(publicKey->W, out);
-    return true;
-}
-
-/**
- * @deprecated
- * See #getEthAddressFromRawKey
- */
-DEPRECATED static inline bool getEthAddressStringFromKey(cx_ecfp_public_key_t *publicKey,
-                                                         uint8_t *out,
-                                                         cx_sha3_t *sha3Context,
-                                                         uint64_t chainId) {
-    UNUSED(sha3Context);
-
-    getEthAddressStringFromRawKey(publicKey->W, (char *) out, chainId);
-    return true;
-}
-
 bool getEthAddressStringFromBinary(uint8_t *address,
                                    char out[static ADDRESS_LENGTH * 2],
                                    uint64_t chainId);

diff --git a/src_plugin_sdk/CHANGELOG.md b/src_plugin_sdk/CHANGELOG.md
@@ -5,7 +5,15 @@
 | :rotating_light:     | Breaks build                  |
 | :warning:            | Breaks compatibility with app |
 
-## [latest](/) - 2024/02/07
+## [latest](/) - 2024/03/27
+
+### Changed
+
+* Add new functions `getEthAddressFromRawKey` and `getEthAddressStringFromRawKey`
+* Simplify crypto calls in `getEthAddressStringFromBinary`
+* Cleanup useless `cx_sha3_t` useless parameter
+
+## [0a98664](/../../commit/0a98664) - 2024/02/07
 
 ### Removed
 

diff --git a/tests/speculos/test_configuration_cmd.py b/tests/speculos/test_configuration_cmd.py
@@ -1,3 +1,3 @@
 
 def test_configuration(cmd):
-    assert cmd.get_configuration() == (2, 1, 11, 1)
+    assert cmd.get_configuration() == (2, 1, 11, 0)