-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove support for U2F #522
Conversation
@apaillier-ledger I think we already discussed about it.
Note that there is still a usb disconnexion / reconnexion when moving from an app to an another, even if there is no PID change (which might lead to a smooth handling from Chrome?). Though part of this behavior might change in future OS. |
I just checked to see for any previous context, and I've seen one other attempt at removing this but not a lot of info there 😅 . This is what I've been able to find for now:
I've noticed that as well, for now, it seems to be picking up the device cleanly as long as the PID is the same 👍 |
U2F was left activated in order to work with Firefox which does not support WebHID (since it is not yet standard / still experimental). |
I see, let's keep U2F then👍 I believe the latest firefox browser still supports it through config flags Do you happen to know why the PID is being mutated based on which protocols it speaks? Is that standardized somewhere, I haven't seen any other USB devices do this 😄 Disabling U2F was just a means to an end, to get a stable PID with the other apps. |
I'm afraid I don't know the history behind this decision. |
U2F support will be removed in next release. |
Description
This PR deprecates U2F as supported protocol.
In reality, this hasn't been useable for a long time since Chrome has deprecated U2F API for a while now..
U2F has been a thorn in the eye of WebUSB and has been hampering the user experience for the web.
When
HAVE_IO_U2F
is enabled, it will also mangle the USB ProductID (PID). If you switch into the Ethereum application, the USB PID changes from0x5011
to0x5015
and the Chrome/Brave browser will identifiy it as a "different" device. This forces web developers to re-trigger the 'USB Pairing' screen.Changes include
Breaking changes
Disable U2F.
Additional comments
0x5011
and allow for smooth transitioning between them.