Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-712 address substitution #527

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

apaillier-ledger
Copy link
Contributor

Description

The EIP-712 feature can now display addresses as ERC-20 tickers or as trusted domain names (ENS) if the information has been given to the app beforehand.
The in-app verbose setting still shows these addresses as-is.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger apaillier-ledger force-pushed the feat/apa/eip712_address_substitution branch 5 times, most recently from 0d539c6 to 2df7074 Compare February 5, 2024 17:18
@apaillier-ledger apaillier-ledger force-pushed the feat/apa/eip712_address_substitution branch from 2df7074 to 3319158 Compare February 13, 2024 16:48
@apaillier-ledger apaillier-ledger force-pushed the feat/apa/eip712_address_substitution branch from 3319158 to faa2d3a Compare February 14, 2024 11:10
@apaillier-ledger apaillier-ledger merged commit 87c7b98 into develop Feb 14, 2024
95 of 99 checks passed
@apaillier-ledger apaillier-ledger deleted the feat/apa/eip712_address_substitution branch February 14, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants