Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin_sdk changelog after B2CA-1247 #557

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Update plugin_sdk changelog after B2CA-1247 #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b27bfdc
Revert "Update version to 1.11.1"
cedelavergne-ledger Mar 27, 2024
a14418b
Revert "Adapt test using App version"
cedelavergne-ledger Mar 27, 2024
7e6ae35
Document plugin_sdk changelog
cedelavergne-ledger Mar 27, 2024
1a8bb93
Remove old funtion in deprecated
cedelavergne-ledger Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ APP_LOAD_PARAMS += --path "1517992542'/1101353413'"

APPVERSION_M = 1
APPVERSION_N = 11
APPVERSION_P = 1
APPVERSION_P = 0
APPVERSION = $(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)-dev
APP_LOAD_FLAGS = --appFlags 0xa40 --dep Ethereum:$(APPVERSION)

Expand Down
27 changes: 0 additions & 27 deletions src_common/common_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,33 +63,6 @@ void getEthAddressStringFromRawKey(const uint8_t raw_pubkey[static 65],
char out[static ADDRESS_LENGTH * 2],
uint64_t chainId);

/**
* @deprecated
* See #getEthAddressFromRawKey
*/
DEPRECATED static inline bool getEthAddressFromKey(cx_ecfp_public_key_t *publicKey,
uint8_t *out,
cx_sha3_t *sha3Context) {
UNUSED(sha3Context);

getEthAddressFromRawKey(publicKey->W, out);
return true;
}

/**
* @deprecated
* See #getEthAddressFromRawKey
*/
DEPRECATED static inline bool getEthAddressStringFromKey(cx_ecfp_public_key_t *publicKey,
uint8_t *out,
cx_sha3_t *sha3Context,
uint64_t chainId) {
UNUSED(sha3Context);

getEthAddressStringFromRawKey(publicKey->W, (char *) out, chainId);
return true;
}

bool getEthAddressStringFromBinary(uint8_t *address,
char out[static ADDRESS_LENGTH * 2],
uint64_t chainId);
Expand Down
10 changes: 9 additions & 1 deletion src_plugin_sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,15 @@
| :rotating_light: | Breaks build |
| :warning: | Breaks compatibility with app |

## [latest](/) - 2024/02/07
## [latest](/) - 2024/03/27

### Changed

* Add new functions `getEthAddressFromRawKey` and `getEthAddressStringFromRawKey`
* Simplify crypto calls in `getEthAddressStringFromBinary`
* Cleanup useless `cx_sha3_t` useless parameter

## [0a98664](/../../commit/0a98664) - 2024/02/07

### Removed

Expand Down
2 changes: 1 addition & 1 deletion tests/speculos/test_configuration_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@

def test_configuration(cmd):
assert cmd.get_configuration() == (2, 1, 11, 1)
assert cmd.get_configuration() == (2, 1, 11, 0)
Loading