NBGL porting: improve EIP191 #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedelavergne-ledger
force-pushed
the
cev/B2CA-1558_eip191-streaming
branch
5 times, most recently
from
67054ec to
316879b
Compare
apaillier-ledger
force-pushed
the
cev/B2CA-1558_eip191-streaming
branch
from
316879b to
fbde8e1
Compare
apaillier-ledger
force-pushed
the
cev/B2CA-1558_eip191-streaming
branch
4 times, most recently
from
cc688a4 to
29ffb6a
Compare
* Skip * Page chunking
- Use defined firmware instead of strings - Fix compatibility with Python 3.9 - Fix test navigation steps
apaillier-ledger
force-pushed
the
cev/B2CA-1558_eip191-streaming
branch
from
29ffb6a to
43adc49
Compare
apaillier-ledger
approved these changes
Jul 22, 2024
tdejoigny-ledger
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port message review to
nbgl_useCaseReviewStreamingXXXinui_sign_message.c