Permit (ERC-2612) amount-join filtering #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaillier-ledger
force-pushed
the
feat/apa/permit_amount_filtering
branch
from
071f308 to
205d9c3
Compare
apaillier-ledger
force-pushed
the
feat/apa/permit_amount_filtering
branch
from
205d9c3 to
a95e690
Compare
cedelavergne-ledger
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Permit messages have their token address in the verifyingContract field of the domain, so amount-join filtering had to be modified to support this special case.
https://github.com/ethereum/ercs/blob/master/ERCS/erc-2612.md
Changes include