Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify TLV parsing #709

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Unify TLV parsing #709

merged 2 commits into from
Jan 9, 2025

Conversation

apaillier-ledger
Copy link
Contributor

Description

Make all the existing features using TLV use the new parser that came with the generic parser.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger apaillier-ledger force-pushed the feat/apa/unify_tlv_parsing branch from dc5e251 to cf49174 Compare January 8, 2025 17:11
@apaillier-ledger apaillier-ledger marked this pull request as ready for review January 8, 2025 17:29
@cedelavergne-ledger
Copy link
Contributor

During the tests, I noticed errors with Ledger-PKI which has not been updated after being changed from Domain Name to Trusted Name. The following APDU certificate metadata should have been updated: Trusted Name and Key Usage.

@apaillier-ledger apaillier-ledger force-pushed the feat/apa/unify_tlv_parsing branch 4 times, most recently from 769427d to cf49174 Compare January 9, 2025 14:50
@apaillier-ledger apaillier-ledger merged commit b15f948 into develop Jan 9, 2025
340 of 345 checks passed
@apaillier-ledger apaillier-ledger deleted the feat/apa/unify_tlv_parsing branch January 9, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants