Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B2CA-1881: Add web3check feature #724

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

B2CA-1881: Add web3check feature #724

wants to merge 11 commits into from
+2,364 −260

Conversation

cedelavergne-ledger
Copy link
Contributor

Description

  • Add setting to enable web3check

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@cedelavergne-ledger cedelavergne-ledger changed the title B2C1-1881: Add web3check feature B2CA-1881: Add web3check feature Jan 28, 2025
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1881_W3C branch 13 times, most recently from 5f5a061 to 73cfae5 Compare February 5, 2025 14:47
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1881_W3C branch 4 times, most recently from 4d39f36 to eeadf6f Compare February 7, 2025 09:03
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1881_W3C branch 10 times, most recently from a840c39 to 86cc0bc Compare February 12, 2025 16:20
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1881_W3C branch 3 times, most recently from 632983d to 50276e1 Compare February 13, 2025 14:28
@cedelavergne-ledger
Add helper script to generate TX SIMULATION APDU
f18a1e9
@cedelavergne-ledger
Add web3check settings
4933fa1 
- One setting to enable/disable the feature
- One hidden setting to indicate if the user has Opt-In
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1881_W3C branch 2 times, most recently from bf5a358 to 0da0a9f Compare February 25, 2025 18:47
Copilot
Copilot AI reviewed Feb 25, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 301 out of 301 changed files in this pull request and generated 3 comments.

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1881_W3C branch 2 times, most recently from a03d16e to c27a563 Compare February 26, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cedelavergne-ledger @tdejoigny-ledger