B2CA-1942: nbgl on nano #736
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedelavergne-ledger
force-pushed
the
cev/B2CA-1942_nbgl-on-nano
branch
2 times, most recently
from
075b79c to
e9558a1
Compare
There was a problem hiding this comment.
Copilot reviewed 1341 out of 1358 changed files in this pull request and generated no comments.
Files not reviewed (17)
- Makefile: Language not supported
- glyphs/chain_108_14px.gif: Language not supported
- glyphs/chain_1284_14px.gif: Language not supported
- glyphs/chain_1285_14px.gif: Language not supported
- glyphs/chain_1313114_14px.gif: Language not supported
- glyphs/chain_1620_14px.gif: Language not supported
- glyphs/chain_1666600000_14px.gif: Language not supported
- glyphs/chain_1987_14px.gif: Language not supported
- glyphs/chain_19_14px.gif: Language not supported
- glyphs/chain_1_14px.gif: Language not supported
- glyphs/chain_200625_14px.gif: Language not supported
- glyphs/chain_20531812_14px.gif: Language not supported
- glyphs/chain_237_14px.gif: Language not supported
- glyphs/chain_24484_14px.gif: Language not supported
- glyphs/chain_246529_14px.gif: Language not supported
- glyphs/chain_246_14px.gif: Language not supported
- glyphs/chain_248_14px.gif: Language not supported
Comments suppressed due to low confidence (1)
client/src/ledger_app_clients/ethereum/settings.py:31
- Ensure that the new logic for
xandycoordinates inget_setting_positionis covered by tests.
def get_setting_position(firmware: Firmware, setting_idx: int) -> tuple[int, int]:
3ddb072 to
996571c
Compare
- Disable Network Icons - Piezzo not available - Remove 'SCREEN_SIZE_WALLET' for 'get_ui_pairs_buffer' in eip712 - Update strings to fit in Nano screen - No skip on Nano for eip712
- Do not send big network icons on nano - Fix navigation
cedelavergne-ledger
force-pushed
the
cev/B2CA-1942_nbgl-on-nano
branch
from
996571c to
5c2b9f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the app to use NBGL for NanoX and NanoSP.
Changes include