Align with sdk #740
Merged
Align with sdk #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 64 out of 79 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- src/chainConfig.h: Language not supported
- src/common_ui.h: Language not supported
- src/handle_check_address.c: Language not supported
- src/handle_get_printable_amount.c: Language not supported
- src/handle_swap_sign_transaction.c: Language not supported
- src/manage_asset_info.c: Language not supported
- src/manage_asset_info.h: Language not supported
- src/mem_utils.h: Language not supported
- src/network.c: Language not supported
- src/shared_context.h: Language not supported
- src/ui_callbacks.h: Language not supported
- client/src/ledger_app_clients/ethereum/command_builder.py: Evaluated as low risk
- client/src/ledger_app_clients/ethereum/keychain.py: Evaluated as low risk
- client/src/ledger_app_clients/ethereum/settings.py: Evaluated as low risk
- .github/workflows/codespell.yml: Evaluated as low risk
cedelavergne-ledger
force-pushed
the
cev/align_with_sdk
branch
from
65c9ee5 to
43c4a47
Compare
cedelavergne-ledger
force-pushed
the
cev/align_with_sdk
branch
from
9ba7d74 to
7a98093
Compare
apaillier-ledger
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix API update for nbgl_useCaseAdvancedReview
Fix UI issue with swap
Cleanup/Linter