Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for Quality Control section of "Basic Quality Assurance and Control, and Data Manipulation in Spreadsheets" #75

Closed
sararasmussn opened this issue Jan 3, 2020 · 2 comments
Labels
help wanted Looking for Contributors

Comments

@sararasmussn
Copy link

For the episode "Basic Quality Assurance and Control, and Data Manipulation in Spreadsheets", I would suggest these edits to the Quality Control section:

  • The tip about version control and the readme paragraph below are related, but it's not clear whether these are theoretical concepts to be explained to learners, or whether they are part of the hands-on process.
  • If time allows, I would suggest incorporating hands-on steps because then learners have practice with the idea presented. At the very least, an example in the narrative would help illustrate each of these steps, maybe broken into a numbered list because while brief, these paragraphs pack a lot of information.
  • Stylistically, I would suggest making these the same text format; one as a tip and one as a free-floating paragraph is a little disjointed.

Thank you for your consideration!

@morskyjezek
Copy link
Contributor

morskyjezek commented Jul 8, 2022

Hi @sararasmussn - thanks for these observations and suggestions! We're always happy to get this sort of feedback and input on the Library Carpentry materials. You make a good point, and in looking over this section of the lesson, I agree that the "Tip!" and advice about readme are not well integrated into the flow of the lesson. The placement in the flow of the lesson A related point was raised about the conflicting advice throughout the lesson about logging actions (#36 ) which in some points is described as a step in a new sheet, and is also mentioned as a separate file. In any case, I see this point as related to the larger issue. For the moment, we haven't been able to address this comment, but I think that we hope to in the near future, so leaving this issue open as a reminder.

I like your suggestion of a hands-on step or example. An activity (eg, save a copy of the file and make your changes there; create a readme file) may be complicated, as it could add time to the lesson, and also I think it would also make more sense for an activity like that to occur in the first or second episodes rather than at this later stage in the lesson.

@jt14den jt14den added the help wanted Looking for Contributors label Jun 4, 2024
@morskyjezek
Copy link
Contributor

Thank you again for this suggestion. The issue has been open for some time, and as I'm reviewing suggestions and changes, this one seems to be addressed in the new PR #155 - this change suggested use of the README was the required option (removed the ambiguity), and it also provides some specific examples about what to put in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Looking for Contributors
Projects
None yet
Development

No branches or pull requests

3 participants