Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Brief Summary By" field parameters too strict #123

Closed
twinkietoes-on opened this issue May 25, 2021 · 0 comments
Closed

"Brief Summary By" field parameters too strict #123

twinkietoes-on opened this issue May 25, 2021 · 0 comments

Comments

@twinkietoes-on
Copy link
Collaborator

"When I submit the form, it gives me the following error and also deletes the recorded language choice and the selected author."

The Brief Summary By field may only contain alpha-numeric characters, underscores, spaces and dashes.

Sometimes other characters are used (parentheses, slashes, etc.) so this needs to be less strict.
@ITD88 ITD88 mentioned this issue Nov 23, 2021
Closed
kgroeneveld added a commit to kgroeneveld/librivox-catalog that referenced this issue Dec 31, 2021
@kgroeneveld
Relax "Brief Summary By" field validation.
84aac12 
Previously only alpha, dash and space were allowed. However it is desirable
to also allow things such as slashes and parentheses.

(The same commit was also submitted in a PR by ITD88 but was combined with
other completely unrelated changes with a less descriptive log message.)

Fixes LibriVox#123.
@kgroeneveld kgroeneveld mentioned this issue Dec 31, 2021
Merged
kgroeneveld added a commit to kgroeneveld/librivox-catalog that referenced this issue Dec 31, 2021
@kgroeneveld
Relax "Brief Summary By" field validation.
05f9872 
Previously only alpha, dash and space were allowed. However it is desirable
to also allow things such as slashes and parentheses.

(The same commit was also submitted in a PR by ITD88 but was combined with
other completely unrelated changes with a less descriptive log message.)

Fixes LibriVox#123.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Brief Summary By less strict ITD88/librivox-catalog
1 participant
@twinkietoes-on