Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekly/Fortnightly Poetry Template: Date doesn't transfer in #124

Closed
twinkietoes-on opened this issue Jul 5, 2021 · 0 comments · Fixed by #136
Closed

Weekly/Fortnightly Poetry Template: Date doesn't transfer in #124

twinkietoes-on opened this issue Jul 5, 2021 · 0 comments · Fixed by #136

Comments

@twinkietoes-on
Copy link
Collaborator

Is this a bug or a feature? :)

The templates return [b]Deadline:[/b] Please submit your recording by [b]0600 GMT Sunday, DATE (12:00 AM CST)[/b]

It would be nice if it plugged in the date submitted in the form rather than "DATE".
kgroeneveld added a commit to kgroeneveld/librivox-catalog that referenced this issue Dec 30, 2021
@kgroeneveld
Use entered date in poetry project launch template output.
db67c0b 
Previously the poetry templates would always show "Sunday, DATE" (or a
translated equivalent) as a placeholder that then needed to be manually
updated.

Note that the generated date text in the template output is in English
even if another language is selected. It could be a lot of work to generate
these strings properly in all the languages and currently the poetry
templates are only being used for English. Even if these are used for
non English the results are no worse than before as they already needed
to be manually updated to replace the fixed placeholder.

This fixes LibriVox#124.
kgroeneveld added a commit to kgroeneveld/librivox-catalog that referenced this issue Dec 31, 2021
@kgroeneveld
Use entered date in poetry project launch template output.
fad4202 
Previously the poetry templates would always show "Sunday, DATE" (or a
translated equivalent) as a placeholder that then needed to be manually
updated.

Note that the generated date text in the template output is in English
even if another language is selected. It could be a lot of work to generate
these strings properly in all the languages and currently the poetry
templates are only being used for English. Even if these are used for
non English the results are no worse than before as they already needed
to be manually updated to replace the fixed placeholder.

This fixes LibriVox#124.
@kgroeneveld kgroeneveld mentioned this issue Dec 31, 2021
Merged
notartom pushed a commit that referenced this issue Dec 31, 2021
@kgroeneveld @notartom
Use entered date in poetry project launch template output.
b0e6bc5 
Previously the poetry templates would always show "Sunday, DATE" (or a
translated equivalent) as a placeholder that then needed to be manually
updated.

Note that the generated date text in the template output is in English
even if another language is selected. It could be a lot of work to generate
these strings properly in all the languages and currently the poetry
templates are only being used for English. Even if these are used for
non English the results are no worse than before as they already needed
to be manually updated to replace the fixed placeholder.

This fixes #124.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use entered date in poetry project launch template output. kgroeneveld/librivox-catalog
1 participant
@twinkietoes-on