Make German project template consistent #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ITD88
changed the title
ITD88
changed the title
|
Yeah, the GitHub pull request is weird to me as well. You can think of it as asking to merge your branch into master, so whatever commits you add to your branch will become part of the pull request. I think the generally accepted workflow is to have one branch per topic, or issue to fix, and then open one pull request for each branch. In any case, thanks for putting in the effort! I've taken the liberty of rewording your commits (and fixing the template.php one, you missed multiplying by 1024 in the non-error part of the code), and pushing them directly as 5f19782 and 3d0c92f). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #125
Edit: I'm sorry, github confuses me so much. I wanted to create a second pull request for a separate issue but now it has put both together.
The second issue is that the uploader gives one filesize when you start uploading and a much small filesize when you finish. This is because this file is converting the filesize to kb after upload and that size is being interpretted as bytes. Multiplying by 1024 reverses this.