Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since CI3 we are not being logged out of the workflow until cookies are cleared #143

Closed
notartom opened this issue Oct 15, 2022 · 2 comments

Comments

@notartom
Copy link
Member

Since this change (I think, or shortly thereafter with one of the subsequent changes), we are not being logged out of the workflow until cookies are cleared. Is this a security issue that we would want to address, or is it okay?
(EDIT to add: I accept cookies until I close my browser, so I'm not logged out unless I do that, which can be days or more where the workflow is accessible on my computer.)

Originally posted by @twinkietoes-on in #7 (comment)

@notartom notartom changed the title Since CI3 (I think, or shortly thereafter with one of the subsequent changes), we are not being logged out of the workflow until cookies are cleared Since CI3 we are not being logged out of the workflow until cookies are cleared Oct 15, 2022
@twinkietoes-on
Copy link
Collaborator

twinkietoes-on commented Oct 15, 2022

Oh, we're definitely being logged out of the workflow now. I don't know the time limit, but it's somewhere between 10 and 20 minutes (and drives me crazy every time I get caught trying to edit something on a page I'm logged out of). LOL

@redrun45
Copy link
Collaborator

Workflow keeps us logged in as it ought to now, so I think we can close this issue.

I'm looking around to see where I might most helpfully dig in. With any luck, I'll find another few issues already fixed, as I look around. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants