Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader page access ignores query string #158

Closed
twinkietoes-on opened this issue Feb 15, 2023 · 3 comments
Closed

Reader page access ignores query string #158

twinkietoes-on opened this issue Feb 15, 2023 · 3 comments

Comments

@twinkietoes-on
Copy link
Collaborator

(I hope this is clear enough. It's just beyond my thorough understanding. I'm copy/pasting.)

Any access to the reader page (eg, https://librivox.org/reader/8463) clobbers the querystring.
For example:
https://librivox.org/reader/8463?primary_key=8463&search_category=reader&search_page=4&search_form=get_results

The query includes the parameter "search_page=4", so the expected behavior would be to display results starting on page 4. Instead the search script ignores the entire querystring and displays the first page of results.

https://forum.librivox.org/viewtopic.php?p=2156227#p2156227

@redrun45
Copy link
Collaborator

Thanks to garethsime (thank you!), we no longer lose the page on reader searches. We might close this as fixed, since I don't see anything else there to be broken by the clobbering.

@notartom
Copy link
Member

So as @garethsime said in #167, his patch fixes Author, Group, and Reader pages. Are there other pages where the query string is being ignored that haven't been fixed by his patch?

@redrun45
Copy link
Collaborator

Not that I'm aware of. I think if we run into any more such issues, we can file them separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants