Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved section moves back in Section Compiler after another section deleted #168

Closed
twinkietoes-on opened this issue May 24, 2023 · 0 comments · Fixed by #240
Closed

Moved section moves back in Section Compiler after another section deleted #168

twinkietoes-on opened this issue May 24, 2023 · 0 comments · Fixed by #240
Labels
priority:high

Comments

@twinkietoes-on
Copy link
Collaborator

In the Section Compiler, I move a section to a new spot. It renumbers all sections as expected.
Then I delete a different section using the X.
Result: The section I deleted is properly deleted, but the section I had moved jumps back to its original location while retaining its new section number.

Expected action: The section I moved should stay where I moved it.

To mitigate: After moving the section, refreshing/reloading the page will "set" the section, so I may then delete others without it jumping back to its original position. But this is a pain.

Video demonstration: https://youtu.be/Dysu1RblXuI
redrun45 added a commit to redrun45/librivox-catalog that referenced this issue Aug 18, 2024
@redrun45
Fix LibriVox#168: moved section moves back after delete
6336a3f 
Our 'jquery.dataTables' library updates its internal state when
 `fnDeleteRow()` is called. That update ignores and overrides the last
 drag-and-drop operation.
This gives us two options: refresh the entire page (since the server has
 received the correct order), or remove sections _directly_, then call
 something else to update dataTables' state.  Here, we use option 2.
@redrun45 redrun45 mentioned this issue Aug 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Section compiler fixes redrun45/librivox-catalog
1 participant
@twinkietoes-on