Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section compiler fixes #240

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Conversation

redrun45
Copy link
Collaborator

Fixes #168. Sections that you have moved do not "jump back" to their previous locations when you delete another section.

Progress toward #36, removing white-space from inputs in Section Compiler. There are still edge-cases elsewhere, though.

We're already doing XSS cleaning, but in a couple of edge cases, we left
 leading and trailing spaces.  Also, there should never be HTML tags in
 section titles.
In both cases, this logic is on the server side.  It might be nice to
 surface this for the clients, and/or to use the validation library to
 add more constraints, but this is a step forward.
Our 'jquery.dataTables' library updates its internal state when
 `fnDeleteRow()` is called. That update ignores and overrides the last
 drag-and-drop operation.
This gives us two options: refresh the entire page (since the server has
 received the correct order), or remove sections _directly_, then call
 something else to update dataTables' state.  Here, we use option 2.
@notartom notartom merged commit 063ac1a into LibriVox:master Aug 18, 2024
1 check passed
@redrun45 redrun45 deleted the section-compiler-fixes branch August 18, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moved section moves back in Section Compiler after another section deleted
2 participants