More consistent ordering of autocomplete results #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pseudonyms are now properly sorted (an edge case remains when both the
"real" name and pseudonym are suggested at once)
- We ignore leading spaces, for the purpose of sorting
- We sort by firstname, lastname in most cases. We reverse that order
when searching by first name _only_.
Co-authored-by: peterjdann <[email protected]>
notartom
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with admins (and with thanks to Peter/TheBanjo for suggesting it), this adjusts the order of autocomplete suggestions. This seems small enough to go live. 👍
In case someone's leery of
COALESCE(), I can confirm that it does NOT mix separate data rows here. It returns the first not-null argument that is fed to it, as it is run on each individual row.For example, if I were to call
COALESCE( A, B )on a table like this:...then the result would be this:
No fear of mixing the rows!