Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add cover image to API #245

Closed
fakerybakery opened this issue Nov 4, 2024 · 1 comment · Fixed by #246
Closed

Feature Request: Add cover image to API #245

fakerybakery opened this issue Nov 4, 2024 · 1 comment · Fixed by #246
Labels
area:api API and RSS - resources for third-party automed access good first issue priority:medium

Comments

@fakerybakery
Copy link
Contributor

Hi,
Thanks for releasing the LibriVox API! Would it be possible to add the cover image to the API?
Thanks!

@redrun45
Copy link
Collaborator

redrun45 commented Nov 5, 2024

I'm sure it would be possible, yes! We've got 3 URL columns in the database for them (for the cover, its thumbnail, and a jacket-sleeve PDF), so those could be made public as part of the API. When projects first get published, they usually won't have any of the three, so API 'consumers' may have to refresh the data later.

I don't plan on implementing this myself any time soon - I'm more focused on bug-hunting and improving the direct experience of our web site, in the limited time I have for code. Someone else might swoop in to do it, or if you yourself come in with a PR, I'd be willing to help test it sooner than I would write and test it myself.

For anyone looking into this, I'd put eyes on application/libraries/Librivox_API.php. I'd imagine these belong among the 'extended' properties, but I know just enough about APIs to be dangerous.

@redrun45 redrun45 added the area:api API and RSS - resources for third-party automed access label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api API and RSS - resources for third-party automed access good first issue priority:medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants