From 1d541030357f5f2a04325554fd0a92d1afb8c759 Mon Sep 17 00:00:00 2001 From: "aseem.kannal" Date: Sun, 18 Aug 2024 20:05:56 -0700 Subject: [PATCH 1/3] added ignore for hypter params --- src/lightning/pytorch/utilities/parsing.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lightning/pytorch/utilities/parsing.py b/src/lightning/pytorch/utilities/parsing.py index 0f4460a3d5144..abf1b5a12d048 100644 --- a/src/lightning/pytorch/utilities/parsing.py +++ b/src/lightning/pytorch/utilities/parsing.py @@ -201,6 +201,9 @@ def save_hyperparameters( obj._hparams_name = "kwargs" # `hparams` are expected here + + # filter out hp based on ignore list + hp = {k: v for k, v in hp.items() if k not in ignore} obj._set_hparams(hp) for k, v in obj._hparams.items(): From be440b14e050298aa025a661d3b7a9111f058e61 Mon Sep 17 00:00:00 2001 From: "aseem.kannal" Date: Sun, 18 Aug 2024 22:14:48 -0700 Subject: [PATCH 2/3] explicitly convert hyper params variable to a dict before filtering with ignore --- src/lightning/pytorch/utilities/parsing.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lightning/pytorch/utilities/parsing.py b/src/lightning/pytorch/utilities/parsing.py index abf1b5a12d048..cd64873812597 100644 --- a/src/lightning/pytorch/utilities/parsing.py +++ b/src/lightning/pytorch/utilities/parsing.py @@ -19,6 +19,7 @@ import types from dataclasses import fields, is_dataclass from typing import Any, Dict, List, Literal, MutableMapping, Optional, Sequence, Tuple, Type, Union +from argparse import Namespace from torch import nn @@ -203,6 +204,8 @@ def save_hyperparameters( # `hparams` are expected here # filter out hp based on ignore list + if isinstance(hp, Namespace): + hp = vars(hp) hp = {k: v for k, v in hp.items() if k not in ignore} obj._set_hparams(hp) From 360653e488055cd01bd1e6ef2dd3c9ede6af91b1 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 19 Aug 2024 05:15:09 +0000 Subject: [PATCH 3/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- src/lightning/pytorch/utilities/parsing.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lightning/pytorch/utilities/parsing.py b/src/lightning/pytorch/utilities/parsing.py index cd64873812597..4fab4bea60784 100644 --- a/src/lightning/pytorch/utilities/parsing.py +++ b/src/lightning/pytorch/utilities/parsing.py @@ -17,9 +17,9 @@ import inspect import pickle import types +from argparse import Namespace from dataclasses import fields, is_dataclass from typing import Any, Dict, List, Literal, MutableMapping, Optional, Sequence, Tuple, Type, Union -from argparse import Namespace from torch import nn @@ -205,7 +205,7 @@ def save_hyperparameters( # filter out hp based on ignore list if isinstance(hp, Namespace): - hp = vars(hp) + hp = vars(hp) hp = {k: v for k, v in hp.items() if k not in ignore} obj._set_hparams(hp)