Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate GPU test and publish #286

Closed
Borda opened this issue Oct 12, 2023 · 2 comments
Closed

consolidate GPU test and publish #286

Borda opened this issue Oct 12, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Borda
Copy link
Member

Borda commented Oct 12, 2023

🚀 Feature

Let's re-consider the advantage of running pytest (e.g. pytest -v notebook.ipynb --nbval) since notebooks in most cases do not include any real pytest case (well, I do not see any)

Pitch

simplify the CI/CD processes

Alternatives

adding at least fail fast for pytest-nbval

Additional context

as a disadvantage, it tries to execute all related cell not fail fast which:

  • marked looking for the issue harder as there is too much noise
  • in most cases when the first failing cell hits, no others are passing because of missing expected imports or variables
@speediedan
Copy link
Contributor

Makes sense since the testing was adding minimal marginal value over the publish pipeline. Totally on board with that simplification!

@Borda
Copy link
Member Author

Borda commented Jul 24, 2024

done in #324

@Borda Borda closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants