handle error in epoll_wait_syscall()#1121
Merged
rennergade merged 2 commits intomainfrom Apr 30, 2026
Merged
Conversation
Contributor
End-to-End Test ReportTest PreviewUnified Test Report grate harness
Cases
static harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
wasm harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
|
@drapl0n add a test here please |
Contributor
Author
Failed test: test_fromfd(). It expects EBADF as the return value since fd was closed when |
- replaces unsafe `unwrap()` with error handeling based on Result<> - returns appropriate error code
Contributor
End-to-End Test ReportTest PreviewUnified Test Report grate harness
Cases
static harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
wasm harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
DanielZ224
pushed a commit
that referenced
this pull request
Apr 30, 2026
* handle error in epoll_wait_syscall() - replaces unsafe `unwrap()` with error handeling based on Result<> - returns appropriate error code * add epoll test that accesses epoll fd after being closed
rennergade
added a commit
that referenced
this pull request
May 6, 2026
* Fix statfs guest buffer handling * handle error in epoll_wait_syscall() (#1121) * handle error in epoll_wait_syscall() - replaces unsafe `unwrap()` with error handeling based on Result<> - returns appropriate error code * add epoll test that accesses epoll fd after being closed * add make fpcast shortcut for WITH_FPCAST=1 build * Restore lind debug import helper for debug builds (#1136) * Restore lind debug import helper * Link lind debug object in dynamic builds --------- Co-authored-by: Daniel Zhao <你çzz10239@nyu.edu> * fix getcwd with NULL buffer (#1139) getcwd(NULL, 0) is valid POSIX — glibc should allocate the buffer. Our wrapper passed NULL through TRANSLATE_GUEST_POINTER_TO_HOST which produced a bad pointer, causing the syscall to fail. bash calls getcwd(0, 0) during shell init, triggering "error retrieving current directory" on startup. Allocate a buffer when buf is NULL before calling the syscall. * Change cage epoch to atomicptr (#1125) * Change optimization level from O0 to O2 (#1112) * Change optimization level from O0 to O2 * fix tests for O2 compatibility - filetest.c, filetest1000.c: fix OOB write buffer[WRITE_BUFFER_SIZE] to buffer[WRITE_BUFFER_SIZE - 1] - alarm.c, setitimer.c: add volatile to signal_counter so O2 doesn't optimize out the spin loop - wait.c: convert to asserts, remove sleep and non-deterministic output - fork_large_memory.c: remove intermediate printf, keep single final print * skip statfs test pending O2 investigation --------- Co-authored-by: Nicholas Renner <nicholassrenner@gmail.com> * Increase MAX_CAGEID to 2048 and fix alloc off-by-one (#1140) * Increase MAX_CAGEID to 2048 and fix alloc off-by-one Raise the cage ID limit from 1024 to 2048. Fix off-by-one in alloc_cage_id where the old condition (v <= MAX_CAGEID) could return a cage ID equal to MAX_CAGEID, which is out of bounds for CAGE_MAP. Add fork_max_cages test that exercises the full cage ID space. * Add fork_max_cages to skip list * Enable statfs test in CI * Trigger CI rerun --------- Co-authored-by: Daniel Zhao <你çzz10239@nyu.edu> Co-authored-by: drapl0n <87269662+drapl0n@users.noreply.github.com> Co-authored-by: Nicholas Renner <nicholassrenner@gmail.com> Co-authored-by: Nicholas Renner <nr2185@nyu.edu> Co-authored-by: Alice Wen <40227173+Yaxuan-w@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unwrap()with error handeling based on Result<>This PR resolves the issue causing failure of
test_epolltest incpythonapp.