Skip to content

Conversation

@kathyavini
Copy link
Collaborator

@kathyavini kathyavini commented Oct 21, 2025

Description

This creates the container structure for Market Directory with:

  • expandable header + content where the Market Directory Info container + pure form component can go
  • a consent section (for future container + pure component) that gets a disabled state based on the completion of the above

I went ahead and made the form cards extendable (i.e. made it possible to add more form cards beyond Market Directory Info), even though the first pass of MVP2 does look like a nested tab structure for the additional forms, rather than more cards. I did this because

  • I think we have some wiggle room to push for keeping with cards if it's the easier implementation, and I think it will be
  • the useExpandable hook is fundamentally set up to work with sets of cards. Although we have used it previously with a single expandable and hard-coded itemKey={1}, I think it's quite readable -- maybe even a little more readable 🙂 -- with the .map structure it was designed for. But I'm happy to hear otherwise, if you think this seems like unnecessary complication!

Jira link: https://lite-farm.atlassian.net/browse/LF-5018

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini self-assigned this Oct 21, 2025
@kathyavini kathyavini requested review from a team as code owners October 21, 2025 19:11
@kathyavini kathyavini added enhancement New feature or request new translations New translations to be sent to CrowdIn are present labels Oct 21, 2025
@kathyavini kathyavini requested review from SayakaOno and removed request for a team October 21, 2025 19:11
Copy link
Collaborator

@SayakaOno SayakaOno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! I love how extendable it is, and thank you for making the review easier with the temporary checkbox. It’s fun to play with it 😁

@SayakaOno SayakaOno added this pull request to the merge queue Oct 23, 2025
Merged via the queue into integration with commit afffb39 Oct 23, 2025
4 of 5 checks passed
@SayakaOno SayakaOno deleted the LF-5018-create-containers-and-cards-for-market-directory-tab branch October 23, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request new translations New translations to be sent to CrowdIn are present

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants