Skip to content

LF-5026: Duplicate product created when "Save Product" button is clicked twice quickly for specific product names #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

LF-5026: Duplicate product created when "Save Product" button is clicked twice quickly for specific product names #3910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d8c90c
LF-4530 Update useSaveProduct's onSave to accept onError
SayakaOno Oct 24, 2025
19e0bd5
LF-4530 Disable product form save button while API call is in progress
SayakaOno Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions packages/webapp/src/containers/ProductInventory/ProductForm/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details, see <https://www.gnu.org/licenses/>.
*/
import { useState } from 'react';
import { FormProvider, useForm } from 'react-hook-form';
import { TFunction, useTranslation } from 'react-i18next';
import clsx from 'clsx';
Expand Down Expand Up @@ -100,15 +101,26 @@ export default function ProductForm({
onActionButtonClick,
onCancel,
}: ProductFormProps) {
const [isSaving, setIsSaving] = useState(false);

const { t } = useTranslation();
const formMethods = useForm<ProductFormFields>({ mode: 'onBlur' });
const isAdmin = useSelector(isAdminSelector);

const saveProduct = useSaveProduct({ formMode: mode, productFormType });

const onSave = () => {
setIsSaving(true);

const onSuccess = () => {
onCancel();
setIsSaving(false);
};

const onError = () => setIsSaving(false);

formMethods.handleSubmit((data) => {
saveProduct?.(data, onCancel);
saveProduct?.(data, onSuccess, onError);
})();
};

Expand Down Expand Up @@ -152,7 +164,7 @@ export default function ProductForm({
informationalText={
mode === FormMode.EDIT ? t('ADD_PRODUCT.BUTTON_WARNING') : undefined
}
isDisabled={!formMethods.formState.isValid}
isDisabled={!formMethods.formState.isValid || isSaving}
onConfirm={onSave}
/>
)}
Expand Down
6 changes: 4 additions & 2 deletions packages/webapp/src/containers/ProductInventory/ProductForm/useSaveProduct.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ const useSaveProduct = ({ formMode, productFormType }: UseSaveProductProps) => {

const onSave = async (
data: SoilAmendmentProductFormAllFields,
callback: (product_id: ProductId) => void = () => {},
onSuccess: (product_id: ProductId) => void = () => {},
onError?: () => void,
) => {
if (!formMode || !productFormType) {
return;
Expand All @@ -105,6 +106,7 @@ const useSaveProduct = ({ formMode, productFormType }: UseSaveProductProps) => {
console.error(e);
const message = isNew ? t('message:PRODUCT.ERROR.CREATE') : t('message:PRODUCT.ERROR.UPDATE');
dispatch(enqueueErrorSnackbar(message));
onError?.();
return;
}

Expand All @@ -115,7 +117,7 @@ const useSaveProduct = ({ formMode, productFormType }: UseSaveProductProps) => {
dispatch(enqueueSuccessSnackbar(message));

// Set product_id for the newly created product. Should be called after getProducts()
callback(result.product_id);
onSuccess(result.product_id);
};

dispatch(getProducts({ callback: onProductsFetched }));
Expand Down