Tweak last PR issues

Author: svanharmelen

event_webhook_types.go

@@ -23,7 +23,7 @@ import (
 	"time"
 )
 
-//BuildEvent represents a build event
+// BuildEvent represents a build event.
 //
 // GitLab API docs:
 // https://docs.gitlab.com/ce/user/project/integrations/webhooks.html#build-events
@@ -189,12 +189,12 @@ type IssueCommentEvent struct {
 		NoteableType string  `json:"noteable_type"`
 		AuthorID     int     `json:"author_id"`
 		CreatedAt    string  `json:"created_at"`
-		DiscussionID string  `json:"discussion_id"`
 		UpdatedAt    string  `json:"updated_at"`
 		ProjectID    int     `json:"project_id"`
 		Attachment   string  `json:"attachment"`
 		LineCode     string  `json:"line_code"`
 		CommitID     string  `json:"commit_id"`
+		DiscussionID string  `json:"discussion_id"`
 		NoteableID   int     `json:"noteable_id"`
 		System       bool    `json:"system"`
 		StDiff       []*Diff `json:"st_diff"`

external_status_checks.go

@@ -64,13 +64,14 @@ func (s *ExternalStatusChecksService) ListMergeStatusChecks(pid interface{}, mr
 	return mscs, resp, err
 }
 
-// SetExternalStatusCheckStatusOptions represents the available SetExternalStatusCheckStatus() options.
+// SetExternalStatusCheckStatusOptions represents the available
+// SetExternalStatusCheckStatus() options.
 //
 // GitLab API docs:
 // https://docs.gitlab.com/ee/api/status_checks.html#set-status-of-an-external-status-check
 type SetExternalStatusCheckStatusOptions struct {
-	SHA                   string  `url:"sha" json:"sha"`
-	ExternalStatusCheckID int     `url:"external_status_check_id" json:"external_status_check_id"`
+	SHA                   *string `url:"sha,omitempty" json:"sha,omitempty"`
+	ExternalStatusCheckID *int    `url:"external_status_check_id,omitempty" json:"external_status_check_id,omitempty"`
 	Status                *string `url:"status,omitempty" json:"status,omitempty"`
 }
 
@@ -118,14 +119,15 @@ func (s *ExternalStatusChecksService) ListProjectStatusChecks(pid interface{}, o
 	return pscs, resp, err
 }
 
-// CreateExternalStatusCheckOptions represents the available CreateExternalStatusCheck() options.
+// CreateExternalStatusCheckOptions represents the available
+// CreateExternalStatusCheck() options.
 //
 // GitLab API docs:
 // https://docs.gitlab.com/ee/api/status_checks.html#create-external-status-check
 type CreateExternalStatusCheckOptions struct {
-	Name               string `url:"name" json:"name"`
-	ExternalURL        string `url:"external_url" json:"external_url"`
-	ProtectedBranchIDs *[]int `url:"protected_branch_ids,omitempty" json:"protected_branch_ids,omitempty"`
+	Name               *string `url:"name,omitempty" json:"name,omitempty"`
+	ExternalURL        *string `url:"external_url,omitempty" json:"external_url,omitempty"`
+	ProtectedBranchIDs *[]int  `url:"protected_branch_ids,omitempty" json:"protected_branch_ids,omitempty"`
 }
 
 // CreateExternalStatusCheck creates an external status check.
@@ -156,7 +158,6 @@ func (s *ExternalStatusChecksService) DeleteExternalStatusCheck(pid interface{},
 	if err != nil {
 		return nil, err
 	}
-
 	u := fmt.Sprintf("projects/%s/external_status_checks/%d", PathEscape(project), check)
 
 	req, err := s.client.NewRequest(http.MethodDelete, u, nil, options)
@@ -167,7 +168,8 @@ func (s *ExternalStatusChecksService) DeleteExternalStatusCheck(pid interface{},
 	return s.client.Do(req, nil)
 }
 
-// UpdateExternalStatusCheckOptions represents the available UpdateExternalStatusCheck() options.
+// UpdateExternalStatusCheckOptions represents the available
+// UpdateExternalStatusCheck() options.
 //
 // GitLab API docs:
 // https://docs.gitlab.com/ee/api/status_checks.html#update-external-status-check
@@ -186,7 +188,6 @@ func (s *ExternalStatusChecksService) UpdateExternalStatusCheck(pid interface{},
 	if err != nil {
 		return nil, err
 	}
-
 	u := fmt.Sprintf("projects/%s/external_status_checks/%d", PathEscape(project), check)
 
 	req, err := s.client.NewRequest(http.MethodPut, u, opt, options)