Skip to content

Commit 3acfed7

Browse files
authored
Merge pull request #6 from Lomkit/feature/exposed-limits
♻️ renamed "exposedPaginations" to "exposedLimits"'
2 parents e5a699d + 1277d03 commit 3acfed7

File tree

5 files changed

+19
-5
lines changed

5 files changed

+19
-5
lines changed

Diff for: README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,5 +83,5 @@ TODO
8383
- Custom directives (Filters / sorting)
8484
- Actions / Metrics
8585
- Automatic Gates
86-
- Aggregating (V2)
86+
- Aggregating
8787
- Automatic documentation with extension possible

Diff for: src/Concerns/PerformsModelOperations.php

+15-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ trait PerformsModelOperations
1010
{
1111

1212
/**
13-
* Build a query for the given resource.
13+
* Build a "delete" query for the given resource.
1414
*
1515
* @param \Lomkit\Rest\Http\Requests\RestRequest $request
1616
* @param \Illuminate\Database\Eloquent\Model $query
@@ -20,10 +20,24 @@ public function performDelete(RestRequest $request, Model $model) {
2020
$model->delete();
2121
}
2222

23+
/**
24+
* Build a "restore" query for the given resource.
25+
*
26+
* @param \Lomkit\Rest\Http\Requests\RestRequest $request
27+
* @param \Illuminate\Database\Eloquent\Model $query
28+
* @return void
29+
*/
2330
public function performRestore(RestRequest $request, Model $model) {
2431
$model->restore();
2532
}
2633

34+
/**
35+
* Build a "forceDelete" query for the given resource.
36+
*
37+
* @param \Lomkit\Rest\Http\Requests\RestRequest $request
38+
* @param \Illuminate\Database\Eloquent\Model $query
39+
* @return void
40+
*/
2741
public function performForceDelete(RestRequest $request, Model $model) {
2842
$model->forceDelete();
2943
}

Diff for: src/Concerns/Resource/ConfiguresRestParameters.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function exposedScopes(RestRequest $request) {
5151
return [];
5252
}
5353

54-
public function exposedPaginations(RestRequest $request) {
54+
public function exposedLimits(RestRequest $request) {
5555
return [
5656
10,
5757
25,

Diff for: src/Http/Requests/SearchRequest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function searchRules(Resource $resource, $prefix = '')
3232
[$prefix.'selects' => ['sometimes', 'array']],
3333
$this->selectsRules($resource, $prefix.'selects'),
3434
[
35-
'limit' => ['sometimes', 'integer', Rule::in($resource->exposedPaginations($this))],
35+
'limit' => ['sometimes', 'integer', Rule::in($resource->exposedLimits($this))],
3636
'page' => ['sometimes', 'integer']
3737
],
3838
$prefix === '' ? ['includes' => ['sometimes', 'array']] : [],

Diff for: tests/Support/Rest/Resources/ModelResource.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public function exposedScopes(RestRequest $request)
4141
];
4242
}
4343

44-
public function exposedPaginations(RestRequest $request) {
44+
public function exposedLimits(RestRequest $request) {
4545
return [
4646
1,
4747
10,

0 commit comments

Comments
 (0)