Merge pull request #80 from Lomkit/fix/multiple-rules-validation

🐛 double validation with hooks

Author: GautierDele

src/RestServiceProvider.php

@@ -15,6 +15,15 @@
 use Lomkit\Rest\Console\Commands\ResourceCommand;
 use Lomkit\Rest\Console\Commands\ResponseCommand;
 use Lomkit\Rest\Contracts\QueryBuilder;
+use Lomkit\Rest\Http\Requests\ActionsRequest;
+use Lomkit\Rest\Http\Requests\DestroyRequest;
+use Lomkit\Rest\Http\Requests\DetailsRequest;
+use Lomkit\Rest\Http\Requests\ForceDestroyRequest;
+use Lomkit\Rest\Http\Requests\MutateRequest;
+use Lomkit\Rest\Http\Requests\OperateRequest;
+use Lomkit\Rest\Http\Requests\RestoreRequest;
+use Lomkit\Rest\Http\Requests\RestRequest;
+use Lomkit\Rest\Http\Requests\SearchRequest;
 use Lomkit\Rest\Query\Builder;
 
 class RestServiceProvider extends ServiceProvider
@@ -124,5 +133,15 @@ protected function registerServices()
     {
         $this->app->singleton('lomkit-rest', Rest::class);
         $this->app->bind(QueryBuilder::class, Builder::class);
+
+        $this->app->singleton(RestRequest::class, RestRequest::class);
+        $this->app->singleton(ActionsRequest::class, ActionsRequest::class);
+        $this->app->singleton(DestroyRequest::class, DestroyRequest::class);
+        $this->app->singleton(DetailsRequest::class, DetailsRequest::class);
+        $this->app->singleton(ForceDestroyRequest::class, ForceDestroyRequest::class);
+        $this->app->singleton(MutateRequest::class, MutateRequest::class);
+        $this->app->singleton(OperateRequest::class, OperateRequest::class);
+        $this->app->singleton(RestoreRequest::class, RestoreRequest::class);
+        $this->app->singleton(SearchRequest::class, SearchRequest::class);
     }
 }

tests/Feature/Controllers/MutateCreateOperationsTest.php

@@ -284,6 +284,36 @@ public function test_creating_a_resource_using_pivot_field_not_following_custom_
         $response->assertJsonStructure(['message', 'errors' => ['mutate.0.relations.belongsToManyRelation.0.pivot.number']]);
     }
 
+    public function test_creating_a_resource_with_unique_validation(): void
+    {
+        $modelToCreate = ModelFactory::new()->makeOne([
+            'unique' => 'my unique string',
+        ]);
+        Gate::policy(Model::class, GreenPolicy::class);
+        Gate::policy(BelongsToManyRelation::class, GreenPolicy::class);
+        $response = $this->post(
+            '/api/models/mutate',
+            [
+                'mutate' => [
+                    [
+                        'operation'  => 'create',
+                        'attributes' => [
+                            'unique'   => $modelToCreate->unique,
+                            'name'     => $modelToCreate->name,
+                            'number'   => $modelToCreate->number,
+                        ],
+                    ],
+                ],
+            ],
+            ['Accept' => 'application/json']
+        );
+
+        $this->assertMutatedResponse(
+            $response,
+            [$modelToCreate],
+        );
+    }
+
     public function test_creating_a_resource(): void
     {
         $modelToCreate = ModelFactory::new()->makeOne();

tests/Support/Database/migrations/2023_04_00_000000_create_model_withs_table.php

@@ -17,6 +17,7 @@ public function up()
             $table->string('name');
             $table->bigInteger('number');
             $table->string('string')->nullable();
+            $table->string('unique')->unique()->nullable();
             $table->foreignIdFor(\Lomkit\Rest\Tests\Support\Models\BelongsToRelation::class)->nullable()->constrained();
             $table->timestamps();
         });

tests/Support/Database/migrations/2023_04_00_000000_create_models_table.php

@@ -17,6 +17,7 @@ public function up()
             $table->string('name');
             $table->bigInteger('number');
             $table->string('string')->nullable();
+            $table->string('unique')->unique()->nullable();
             $table->foreignIdFor(\Lomkit\Rest\Tests\Support\Models\BelongsToRelation::class)->nullable()->constrained();
             $table->nullableMorphs('morph_to_relation', 'morph_to_relation_index');
             $table->timestamps();

tests/Support/Rest/Resources/AutomaticGatingResource.php

@@ -31,6 +31,7 @@ public function fields(RestRequest $request): array
             'name',
             'number',
             'string',
+            'unique',
         ];
     }
 }

tests/Support/Rest/Resources/ModelResource.php

@@ -82,6 +82,7 @@ public function fields(RestRequest $request): array
             'name',
             'number',
             'string',
+            'unique',
         ];
     }
 

tests/Support/Rest/Resources/ModelWithResource.php

@@ -18,6 +18,7 @@ public function fields(RestRequest $request): array
             'name',
             'number',
             'string',
+            'unique',
         ];
     }
 

tests/Support/Rest/Resources/NoAuthorizationResource.php

@@ -22,6 +22,7 @@ public function fields(RestRequest $request): array
             'name',
             'number',
             'string',
+            'unique',
         ];
     }
 }