Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter pannel hidden if table is too short #1

Open
shershen08 opened this issue Mar 15, 2017 · 1 comment
Open

Filter pannel hidden if table is too short #1

shershen08 opened this issue Mar 15, 2017 · 1 comment

Comments

@shershen08
Copy link

Here's how it looks (latest Chrome@MacOS) :

screen shot 2017-03-15 at 20 03 55

Should be fixable by CSS overflow:hidden property change of the main table.
I could make PR if you will

@LucienLee
Copy link
Owner

Oh, the overflow: hidden is used to cut the first bloating group date column.
Instead of exploiting rowspan to make grouping cell, I made forged cell with span and set height as the amount of date grouping. The reason is layout would recalculating and cause jerky animation if the first row of the date grouping be filtered.

For example, the date column of second row make the following date columns. When first one row be filtered, the second one has to be replaced the original first one. In that moment, the table would be relayout.

Date Content
March 2014(rowspan="3") 1...
(null) 2...
(null) 3...

You can pull the rowspan br to see what happened.

Anyway, I would fix that and thanks for your report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants