Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions for the web editor #106

Open
EmpathyHeals opened this issue Sep 4, 2019 · 4 comments
Open

Some suggestions for the web editor #106

EmpathyHeals opened this issue Sep 4, 2019 · 4 comments
Labels
enhancement Suggestions to improve the application

Comments

@EmpathyHeals
Copy link

Hi, I am a recent user of LuckPerms, so I'm sorry if any of these are not appropriate or already implemented and I just don't know how to enable/use them. But here are some things that seem like it would make it easier/safer for me as a server owner to use based on first impressions:

  • Make the name of the last person to make the changes using the editor known (right now I'm the only person who can do this as only the owner has this permission, but I had a brief griefing incident in which someone gained access to the console and I was able to see who/what they did using the logs but something simple when typing /lp editor, like last updated by so and so at date/time would be nice).
  • Make a copy of the old file for backup purposes in the directory of the plugin when any changes are implemented using the online editor link. Maybe keep up to 2-3 prior versions then re-write them. This is in case something went badly wrong and it is easier to restore than make new changes.
  • Move the trash can on the editor to the other side, or the left of the name of the permission (or make the line your mouse is over highlight with a certain color). More than once I deleted the wrong perm because the trash can is so far to the right it's hard to see if I'm on the same line.
  • Make an "undo" button or at least a way to see which perm was last deleted so that if it was deleted accidentally it can be added back.
  • Make a search bar where it's possible to see if a permission is anywhere in the file.
  • Make an easier way to identify redundant perms that are already in inherited groups. For example, if rank advocate inherits everything from rank ally, and rank ally already has essentials.warp, then if advocate has essentials.warp too, make the text or highlight the row a different color. This way it's easier to know it's safe to remove.
  • Mark perms that do not belong to any plugin currently in the plugin directory a different color text or highlight the row a different color. I migrated my old pex file to LuckPerms and there were a lot of plugins I didn't install on my new server. Consider making a button that will automatically purge any perms that don't belong to a plugin that's currently active, or at least grab them all and put them on a new page for review. Once sure they shouldn't be kept (not planning on installing that plugin soon), then confirm a "delete all." If any should be kept, make it possible to remove the perm from this page before clicking on "delete all."
    That's all I can think of right now. Thank you for this plugin, it's wonderful overall.
    Emp
@BrainStone
Copy link
Contributor

Make an "undo" button or at least a way to see which perm was last deleted so that if it was deleted accidentally it can be added back.

There's an undo button

Mark perms that do not belong to any plugin currently in the plugin directory a different color text or highlight the row a different color. I migrated my old pex file to LuckPerms and there were a lot of plugins I didn't install on my new server. Consider making a button that will automatically purge any perms that don't belong to a plugin that's currently active, or at least grab them all and put them on a new page for review. Once sure they shouldn't be kept (not planning on installing that plugin soon), then confirm a "delete all." If any should be kept, make it possible to remove the perm from this page before clicking on "delete all."

That is not possible, because it's impossible to know what permissions can be used and which one's can't.

And regarding the other things, LP V5 and the editor V2 are coming soon. And they will introduce some significant changes.

@Andre601
Copy link
Contributor

Andre601 commented Sep 4, 2019

The Web editor is currently in a rewrite together with the v5 of the LuckPerms API.
You can view the current code and the open issues (suggestions) on Turbotailz/LuckPermsWeb

Please open an issue there and not here as this repository has nothing to do with the LuckPerms editor itself.

@BrainStone
Copy link
Contributor

Most of the suggestions weren't even editor specifc. So I think it merely has a bad title but is in the right place.

@lucko lucko transferred this issue from LuckPerms/LuckPerms Dec 2, 2019
@Turbotailz Turbotailz added the enhancement Suggestions to improve the application label Dec 16, 2019
@Zippyduda
Copy link

I would like to second the following improvement:

"Make a search bar where it's possible to see if a permission is anywhere in the file."

Currently the web editor search function only search Tracks, not Groups or Users. Searching Groups for perms or Users for players would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Suggestions to improve the application
Projects
None yet
Development

No branches or pull requests

5 participants