Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation dialog if the editor is closed with unsaved changes #112

Open
nzminecraftDOTcom opened this issue Dec 14, 2019 · 3 comments
Labels
enhancement Suggestions to improve the application

Comments

@nzminecraftDOTcom
Copy link

Some web pages (Gmail etc) prompt you with a pop-up asking if you wish to close the tab and throw away any changes you have made

This would be useful on the editor, because rewriting 50 permissions when you haven't recently saved it is annoying. - Personal experience.

@Turbotailz
Copy link
Member

This should be possible to do, if the editor has modified data and hasn't been saved I can throw a warning before you close the window.

Not sure if this will be more annoying to some people, though. I know I get really annoyed whenever a website does this to me lol.

@nzminecraftDOTcom
Copy link
Author

I'm sure it'll be a pain to some, but it won't need to pop up if they're just opening the page to look at the permissions, without making any changes. If they make changes and don't save they'll probably be relieved that it warned them in most cases.

@BrainStone
Copy link
Contributor

That should be implemented.

@Turbotailz Turbotailz added the enhancement Suggestions to improve the application label Dec 16, 2019
@Turbotailz Turbotailz changed the title Suggestion - Confirm page exit if changes not saved Add confirmation dialog if the editor is closed with unsaved changes Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Suggestions to improve the application
Projects
None yet
Development

No branches or pull requests

3 participants