Improve permission autofill experience

[Andre601]

It is a huge pain for us (the mods) to deal with this, since the changes in dce6009 where introduced.
We constantly get people complaining that the editor "no longer shows the permissions".

In my opinion, is it not worth it to have this for just satisfying a few people, so a revert of this commit until a better solution is found is highly encouraged and appreciated.

[BrainStone]

So you are referring to #121.
Not sure where I posted my original comment on this (maybe in the Discord?) but I'll add it here anyways.
The best solution would be to essentially have the list start with an empty entry as the first entry when nothing is in the field. When that is selected nothing happens.

[Andre601]

I myself made the suggestion to have a text like "Type something to show permissions" instead of the "List is empty" text when the editor has perms available but you didn't type a thing.

But for now should this just be reverted as the amount of people complaining is higher then the amount of people that like this change.

[BrainStone]

Not a "list is empty". But an empty entry at the very top of the list.

So instead of

*
...

It looks like this:

*
...

[Turbotailz]

Done: 9295e7b

Will keep this open for discussion.

[electronicboy]

This is inherently dangerous because if you type in a permission, hit enter, then hit enter again, it will immediately put in *, since * is the first permission suggested.

I posted this on admincrafts discord, shoulda maybe said something on the original issue, but; imho, the best solution to this would be to add a cooldown between adding perms, no idea why people would double press enter, but apparently that was part of the old flow? So, adding an artificial delay might be beneficial here 🤷‍♂

[mbax]

Having, of all things, the * node as the first option for adding perms only encourages bad behavior to begin with. Shove it to the bottom, stick an empty option in as the top option to avoid mistakes, and I don't think anybody gets harmed.

[Andre601]

Or what I suggested multiple times:
If you click the text box and the editor has permissions in the list, don't show "List is empty", but instead a different text like "Type something to list permissions"

The biggest issue that new change has brought is that people instantly assume that the editor is no longer showing any permissions because the text suggest this.

[BrainStone]

Why are you always rambling about a “List is empty” message when there are permissions?
That’s not what’s happening or anyone is suggesting.

[Andre601]

Why are you always rambling about a “List is empty” message when there are permissions?
That’s not what’s happening or anyone is suggesting.

Uhm... It is what people are complaining.
So far every time someone complained that the editor isn't showing permissions, when asking what is shows instead was the answer "List is empty", even tho the editor had cached permissions available and the user only needed to type something.

This is the entire reason of this issue I made. The fact that the editor tells people that the list is empty while there isn't. And since 90% of the people don't know that do they assume that perm-suggestions was removed....

[lucko]

Will post this here too...

Luck - Today at 10:53
About the issue itself, I saw the discussion on GitHub
to clarify, the behaviour I like & would like to see kept is being able to just browse through available permissions without having to type anything
with the change that was reverted, that was only possible after typing something, e.g. you could browse through all permissions starting with a, but not just through everything
does that make sense? :p

Turbotailz - Today at 10:56
I think the main issue is that * is at the top.

Luck - Today at 10:58
I agree with you about the main issue
One more solution which IMO would be ideal would be that after "Press enter to select" - the autocomplete menu could automatically close, and wouldn't open again until the user clicks with their cursor/caret in the "Enter permissions or paste many" box

Turbotailz - Today at 11:05
hmm, I thought it would be useful to keep it open in case there were multiple permissions they wanted to add

Luck - Today at 11:05
hadn't thought about that, yeah fair enough
in which case then, yea
I guess a combination of having the very first entry in the list being an empty string
and sorting * right to the bottom
would work :slight_smile:

[electronicboy]

imho, maybe some bias here, but I feel that all other ideas submitted here kinda potentially infringe of the user flow of adding multiple permissions, the cooldown between adds is a lil' gross, but I kinda don't see why the original issue is an issue in the first place, pressing enter twice is going to submit twice

Could also maybe just have a "none" type entry at the top of the list, or require that the user actually perform some form of interaction to use the list, e.g. pressing the down key to actually move to the suggestions

[BrainStone]

@Andre601 it doesn’t say that the list is empty but rather shows no list at all.

[partydev]

If having an "empty" entry at the top would work, this would solve the issue immediately because an accidental press of enter would result in nothing happening instead of the permission at the top. If it is possible, I support this one.