Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary whitespace in the permission field #72

Closed
Turbotailz opened this issue Dec 4, 2018 · 6 comments
Closed

Remove unnecessary whitespace in the permission field #72

Turbotailz opened this issue Dec 4, 2018 · 6 comments

Comments

@Turbotailz
Copy link
Member

Some users will copy/paste permissions and may sometimes leave whitespace (spaces/tabs) at the end of them which then get added with the node. Use JS to strip extra whitespace on input blur.
@BrainStone
Copy link
Contributor

This can run into issues with prefixes and suffixes. I think they need to be exempt.

@Turbotailz
Copy link
Member Author

Yes, I was going to use trim() which only affects the beginning and end of a string and should not affect prefixes/suffixes with spaces.

@BrainStone
Copy link
Contributor

Yes it will. As they can have intended trailing whitespace.

@BrainStone BrainStone mentioned this issue Dec 4, 2018
Closed
@Turbotailz
Copy link
Member Author

I thought they had to be wrapped in quotes if they had spaces?

@BrainStone
Copy link
Contributor

Only in the commands.

@Turbotailz Turbotailz mentioned this issue Oct 15, 2019
Merged
@Turbotailz
Copy link
Member Author

Closing this in favour of #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BrainStone @Turbotailz