Skip to content

Case Sensitivity #66

@JasperLorelai

Description

@JasperLorelai

It looks like the expansion does not properly handle case insensitivity. The argument (sometimes a perm node) passed to a placeholder is set to lowercase:
https://github.com/LuckPerms/placeholders/blob/master/common/src/main/java/me/lucko/luckperms/placeholders/LPPlaceholderProvider.java#L415

placeholder = placeholder.toLowerCase(Locale.ROOT);

Yet in most placeholders, the lowercased node is being compared against nodes in their original case, failing on nodes which were originally in a case like camel.

builder.addDynamic("inherits_permission", (player, user, userData, queryOptions, node) ->
user.resolveInheritedNodes(queryOptions).stream()
.filter(n -> n.getContexts().isSatisfiedBy(queryOptions.context()))
.anyMatch(n -> n.getKey().equals(node))
);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions