fix: solve and report related problems

Author: RedVortexDev

src/main/java/com/diamondfire/helpbot/bot/command/impl/other/util/SolvedCommand.java

@@ -7,7 +7,7 @@
 import com.diamondfire.helpbot.bot.command.permissions.Permission;
 import com.diamondfire.helpbot.bot.command.reply.PresetBuilder;
 import com.diamondfire.helpbot.bot.command.reply.feature.informative.*;
-import com.diamondfire.helpbot.bot.events.CommandEvent;
+import com.diamondfire.helpbot.bot.events.*;
 import com.diamondfire.helpbot.util.SolvedPostManager;
 import net.dv8tion.jda.api.entities.channel.ChannelType;
 import net.dv8tion.jda.api.entities.channel.concrete.*;
@@ -72,8 +72,8 @@ public void run(CommandEvent event) {
             return;
         }
 
-        // Apply the solved tag.
-        SolvedPostManager.addSolved(threadChannel);
+        /// Apply the solved tag, the [PostChannelEvent] listener will call [SolvedPostManager#addSolved].
+        SolvedPostManager.applySolvedTag(threadChannel);
     }
 
 }

src/main/java/com/diamondfire/helpbot/sys/report/ReportListener.java

@@ -96,8 +96,8 @@ public void onButtonInteraction(@NotNull ButtonInteractionEvent event) {
                 **Thank you for helping keep DiamondFire safe!**
                 * Multiple proofs are allowed.
                 * Proofs can be both **videos and screenshots**.
-                * Uploaded screenshots should be **uncropped**
-                > Meaning, take a __full screenshot__ of your screen.
+                * Uploaded screenshots should be **uncropped**.
+                > Meaning, [take a screenshot](https://www.take-a-screenshot.org/) of your __entire__ screen.
                 * Make sure reports are made in **good faith with valid proof**.
                 """);
 
@@ -185,9 +185,7 @@ private ModalMapping getValue(ModalInteraction event, String customId) {
         // Instead of event#getValue since it returns null when not found,
         // we just assume the components always exist as we already confirm
         // it's the report modal.
-        return event.getValues().stream()
-                .filter(mapping -> mapping.getCustomId().equals(customId))
-                .findFirst().orElseThrow();
+        return event.getValue(customId);
     }
 
 }

src/main/java/com/diamondfire/helpbot/util/SolvedPostManager.java

@@ -7,12 +7,14 @@
 import net.dv8tion.jda.api.entities.channel.concrete.ThreadChannel;
 import net.dv8tion.jda.api.entities.channel.forums.ForumTag;
 import net.dv8tion.jda.api.entities.channel.unions.ChannelUnion;
-import org.jetbrains.annotations.Nullable;
 
 import java.util.*;
 
 public final class SolvedPostManager {
 
+    private static final int CHANNEL_NAME_LIMIT = 100;
+    private static final String ELLIPSIS = "...";
+    
     private SolvedPostManager() {}
 
     public static Optional<ForumTag> getSolvedTag(ThreadChannel channel) {
@@ -26,21 +28,33 @@ public static boolean isSolved(ThreadChannel channel) {
     }
 
     public static void addSolved(ThreadChannel channel) {
+        if (!applySolvedTag(channel)) return;
+        
+        if (!isSolved(channel)) {
+            String newName = "[SOLVED] " + channel.getName();
+            if (newName.length() > CHANNEL_NAME_LIMIT) {
+                newName = newName.substring(0, CHANNEL_NAME_LIMIT - ELLIPSIS.length()) + ELLIPSIS;
+            }
+            channel.getManager().setName(newName).queue();
+        }
+        
+        sendEmbed(channel, "Post marked as solved");
+    }
+    
+    /**
+     * @return true if successful
+     */
+    public static boolean applySolvedTag(ThreadChannel channel) {
         Optional<ForumTag> optionalTag = getSolvedTag(channel);
-        if (optionalTag.isEmpty()) return;
+        if (optionalTag.isEmpty()) return false;
         ForumTag solvedTag = optionalTag.get();
 
         List<ForumTag> tags = new ArrayList<>(channel.getAppliedTags());
         if (!tags.contains(solvedTag)) {
             tags.add(solvedTag);
             channel.getManager().setAppliedTags(tags).queue();
         }
-        
-        if (!isSolved(channel)) {
-            channel.getManager().setName("[SOLVED] " + channel.getName()).queue();
-        }
-        
-        sendEmbed(channel, "Post marked as solved");
+        return true;
     }
 
     public static void removeSolved(ThreadChannel channel) {