Skip to content

Commit 3a7b219

Browse files
committed
Merge branch 'hotfix-v6.3'
This merge addresses two minor issues in MPAS-Atmosphere. 1) The default setting for config_o3climatology was previously 'false', which caused the model to use a single seasonal ozone profile everywhere in the model domain when the RRTMG radiation schemes was used. The default is now 'true', which causes the model to use the same monthly ozone climatology for RRTMG as is used by the CAM radiation schemes. 2) Model simulations using a non-integer timestep would result in 'xtime' variables in model output files that were incorrect, which caused problems when trying to restart the model at the correct time. The xtime variable is now correct when the valid time of output files has no fractional seconds. * hotfix-v6.3: Fix incorrect 'xtime' variable for fractional dt In ./src/core_atmosphere/Registry.xml, switch the default value of the logical config_o3climatology from false to true. Increment version number to 6.3
2 parents ce78c32 + d5590db commit 3a7b219

File tree

10 files changed

+13
-18
lines changed

10 files changed

+13
-18
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
MPAS-v6.2
1+
MPAS-v6.3
22
====
33

44
The Model for Prediction Across Scales (MPAS) is a collaborative project for

src/core_atmosphere/Registry.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
2-
<registry model="mpas" core="atmosphere" core_abbrev="atm" version="6.2">
2+
<registry model="mpas" core="atmosphere" core_abbrev="atm" version="6.3">
33

44
<!-- **************************************************************************************** -->
55
<!-- ************************************** Dimensions ************************************** -->
@@ -1742,7 +1742,7 @@
17421742
description="logical for configuration of deep soil temperatures"
17431743
possible_values=".true. for slowly time-varying deep soil temperatures; .false. otherwise"/>
17441744

1745-
<nml_option name="config_o3climatology" type="logical" default_value="false" in_defaults="false"
1745+
<nml_option name="config_o3climatology" type="logical" default_value="true" in_defaults="false"
17461746
units="-"
17471747
description="logical for configuration of input ozone data in RRMTG long- and short-wave radiation"
17481748
possible_values=".true. for using monthly-varying ozone data; .false. for using fixed vertical profile"/>

src/core_atmosphere/dynamics/mpas_atm_time_integration.F

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ module atm_time_integration
6262
contains
6363

6464

65-
subroutine atm_timestep(domain, dt, timeStamp, itimestep)
65+
subroutine atm_timestep(domain, dt, nowTime, itimestep)
6666
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
6767
! Advance model state forward in time by the specified time step
6868
!
@@ -76,7 +76,7 @@ subroutine atm_timestep(domain, dt, timeStamp, itimestep)
7676

7777
type (domain_type), intent(inout) :: domain
7878
real (kind=RKIND), intent(in) :: dt
79-
character(len=*), intent(in) :: timeStamp
79+
type (MPAS_Time_type), intent(in) :: nowTime
8080
integer, intent(in) :: itimestep
8181

8282

@@ -98,9 +98,8 @@ subroutine atm_timestep(domain, dt, timeStamp, itimestep)
9898
call mpas_log_write('Currently, only ''SRK3'' is supported.', messageType=MPAS_LOG_CRIT)
9999
end if
100100

101-
call mpas_set_time(currTime, dateTimeString=timeStamp)
102101
call mpas_set_timeInterval(dtInterval, dt=dt)
103-
currTime = currTime + dtInterval
102+
currTime = nowTime + dtInterval
104103
call mpas_get_time(currTime, dateTimeString=xtime_new)
105104

106105
block => domain % blocklist

src/core_atmosphere/mpas_atm_core.F

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ function atm_core_init(domain, startTimeStamp) result(ierr)
3636
real (kind=RKIND), pointer :: dt
3737
type (block_type), pointer :: block
3838

39-
character(len=StrKIND) :: timeStamp
4039
integer :: i
4140
logical, pointer :: config_do_restart
4241

@@ -846,7 +845,6 @@ subroutine atm_do_timestep(domain, dt, itimestep)
846845

847846
type (MPAS_Time_Type) :: startTime, currTime
848847
type (MPAS_TimeInterval_Type) :: xtimeTime
849-
character(len=StrKIND) :: timeStamp
850848
integer :: s, s_n, s_d
851849
real (kind=RKIND) :: xtime_s
852850
integer :: ierr
@@ -858,8 +856,6 @@ subroutine atm_do_timestep(domain, dt, itimestep)
858856
call mpas_get_timeInterval(interval=xtimeTime, S=s, S_n=s_n, S_d=s_d, ierr=ierr)
859857
xtime_s = (s + s_n / s_d)
860858

861-
call mpas_get_time(curr_time=currTime, dateTimeString=timeStamp, ierr=ierr)
862-
863859

864860
#ifdef DO_PHYSICS
865861
!proceed with physics if moist_physics is set to true:
@@ -869,7 +865,7 @@ subroutine atm_do_timestep(domain, dt, itimestep)
869865
endif
870866
#endif
871867

872-
call atm_timestep(domain, dt, timeStamp, itimestep)
868+
call atm_timestep(domain, dt, currTime, itimestep)
873869

874870
end subroutine atm_do_timestep
875871

src/core_init_atmosphere/Registry.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
2-
<registry model="mpas" core="init_atmosphere" core_abbrev="init_atm" version="6.2">
2+
<registry model="mpas" core="init_atmosphere" core_abbrev="init_atm" version="6.3">
33

44
<!-- **************************************************************************************** -->
55
<!-- ************************************** Dimensions ************************************** -->

src/core_landice/Registry.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
2-
<registry model="mpas" core="landice" core_abbrev="li" version="6.2">
2+
<registry model="mpas" core="landice" core_abbrev="li" version="6.3">
33

44

55
<!-- ======================================================================= -->

src/core_ocean/Registry.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
2-
<registry model="mpas" core="ocean" core_abbrev="ocn" version="6.2">
2+
<registry model="mpas" core="ocean" core_abbrev="ocn" version="6.3">
33

44
<dims>
55
<dim name="nCells" units="unitless"

src/core_seaice/Registry.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
2-
<registry model="mpas" core="seaice" core_abbrev="seaice" version="6.2">
2+
<registry model="mpas" core="seaice" core_abbrev="seaice" version="6.3">
33

44
<dims>
55
<dim name="nCells"

src/core_sw/Registry.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
2-
<registry model="mpas" core="sw" core_abbrev="sw" version="6.2">
2+
<registry model="mpas" core="sw" core_abbrev="sw" version="6.3">
33
<dims>
44
<dim name="nCells"/>
55
<dim name="nEdges"/>

src/core_test/Registry.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
2-
<registry model="mpas" core="test" core_abbrev="test" version="6.2">
2+
<registry model="mpas" core="test" core_abbrev="test" version="6.3">
33
<dims>
44
<dim name="nCells"/>
55
<dim name="nEdges"/>

0 commit comments

Comments
 (0)