Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver Automation Tool 6.3.0 - Driver package download - Version #172

Open
EvilerBetty opened this issue Jul 30, 2019 · 7 comments
Open

Comments

@EvilerBetty
Copy link

It looks as though Dell is listing some of the driver pack releases as "Version 1.0, A13".
Example: http://downloads.dell.com/published/pages/latitude-12-5290-2-in-1-laptop.html

This results in the Driver Package version being set as "1" when imported into SCCM.

@vartaxe
Copy link
Contributor

vartaxe commented Jul 31, 2019

Oh hell dell is starting to make me crazy

@Alslinet
Copy link

Alslinet commented Oct 2, 2019

Biggest problem with this is the driver pack wont update. Since the Version number never changes. Workaround could be as easy as changing Version number to 0.

@Alslinet
Copy link

Alslinet commented Oct 2, 2019

The problem is this bit of code: (($DriverCab).Split("-")[2]).Trim(".cab")
2-in-1 cab files have additional dashes (-) so it kinda screws With the versioning.

Example:
(("FOLDER05672009M/1/5290 2-IN-1-Win10-A09-8FY5R.CAB").split("-")[2]).Trim(".cab")
(("FOLDER05822961M/1/WinPE10.0-Drivers-A15-FYCJR.CAB").split("-")[2]).Trim(".cab")
(("FOLDER05323227M/1/WinPE3.0-Drivers-A23-MJ53D.CAB").split("-")[2]).Trim(".cab")

Results:
1
A15
A23

@Alslinet
Copy link

Alslinet commented Oct 2, 2019

If you replace the line:
$DriverRevision = (($DriverCab).Split("-")[2]).Trim(".cab")

With something like
$DriverRevision = ($global:DellModelCabFiles | Where-Object {((($_.SupportedOperatingSystems).OperatingSystem).osCode -match "Windows10") -and ($_.SupportedSystems.Brand.Model.SystemID -match "081D")} | Select-Object -Last 1).dellVersion
I think thats all that would be needed, but im not really familiar with the code or why things are done as they are.

@maocul
Copy link

maocul commented Oct 8, 2019

+1 on this issue. my change is probably too simplistic though!

IF ( $DriverCab -like "*2-in-1* ) { $DriverRevision = (($DriverCab).Split("-")[4]).Trim(".cab") } Else { $DriverRevision = (($DriverCab).Split("-")[2]).Trim(".cab") }

We're only dealing with Dell hardware and Windows 10 so I've probably broken a bunch of other functions!

EDIT - I didn't like that so changed to:

$DriverRevision = (($DriverCab).Split("-")[((($DriverCab).Split("-")).count) - 2]).Trim(".cab")

Still entirely possible it will cause other issues, but its working for now!

@skywayskase
Copy link

skywayskase commented Oct 17, 2019

I like the solution suggested by @Alslinet, but unless that's the only model you have, it'll think that every Dell model has that same version.
If you instead replace $DriverRevision = (($DriverCab).Split("-")[2]).Trim(".cab") with something like $DriverRevision = ($Global:DellModelCabFiles | Where-Object {(($_.path).Split("/") | Select-Object -Last 1) -match $DriverCab}).dellVersion it should scale better.

This is tested and working for me. All 14 Dell models now/still have the correct version number.

@Alslinet
Copy link

Alslinet commented Oct 17, 2019

@skywayskase, you are right, i forgot to add that part in before posting. Then realized i would need som further changes. Here is the code. You should be able to identify which part of the script it is that has changed from this. I commented the parts that are changed.

I really need to learn how to do pull requests, see this pastebin for the changes i think will fix this, its the same fix, just for every model this time, should be anyway:
https://pastebin.com/ZSAZUUMC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants