[DOP-28389] Improve group member role check

Author: dolfinus

syncmaster/db/repositories/queue.py

@@ -111,13 +111,13 @@ async def get_group_permission(self, user: User, group_id: int) -> Permission:
         )
 
         user_group = await self._session.scalar(group_role_query)
-        match user_group:
-            case None:
-                return Permission.NONE
-            case GroupMemberRole.Maintainer:
-                return Permission.DELETE
-            case _:
-                return Permission.READ
+        if not user_group:
+            return Permission.NONE
+
+        if user_group == GroupMemberRole.Maintainer:
+            return Permission.DELETE
+
+        return Permission.READ
 
     async def get_resource_permission(self, user: User, resource_id: int) -> Permission:
         """
@@ -162,13 +162,13 @@ async def get_resource_permission(self, user: User, resource_id: int) -> Permiss
         )
 
         user_group = await self._session.scalar(group_role_query)
-        match user_group:
-            case None:
-                return Permission.NONE
-            case GroupMemberRole.Maintainer:
-                return Permission.DELETE
-            case _:
-                return Permission.READ
+        if not user_group:
+            return Permission.NONE
+
+        if user_group == GroupMemberRole.Maintainer:
+            return Permission.DELETE
+
+        return Permission.READ
 
     def _raise_error(self, err: DBAPIError) -> NoReturn:
         constraint = err.__cause__.__cause__.constraint_name  # type: ignore[arg-type, union-attr]

syncmaster/db/repositories/repository_with_owner.py

@@ -53,15 +53,16 @@ async def get_resource_permission(self, user: User, resource_id: int) -> Permiss
         )
 
         user_group = await self._session.scalar(group_role_query)
-        match user_group:
-            case None:
-                return Permission.NONE
-            case GroupMemberRole.Maintainer:
-                return Permission.DELETE
-            case GroupMemberRole.Developer:
-                return Permission.WRITE
-            case _:
-                return Permission.READ
+        if not user_group:
+            return Permission.NONE
+
+        if user_group == GroupMemberRole.Maintainer:
+            return Permission.DELETE
+
+        if user_group == GroupMemberRole.Developer:
+            return Permission.WRITE
+
+        return Permission.READ
 
     async def get_group_permission(self, user: User, group_id: int) -> Permission:
         """Method for determining CRUD permissions in the specified group"""
@@ -92,12 +93,13 @@ async def get_group_permission(self, user: User, group_id: int) -> Permission:
         )
 
         user_group = await self._session.scalar(group_role_query)
-        match user_group:
-            case None:
-                return Permission.NONE
-            case GroupMemberRole.Maintainer:
-                return Permission.DELETE
-            case GroupMemberRole.Developer:
-                return Permission.WRITE
-            case _:
-                return Permission.READ
+        if not user_group:
+            return Permission.NONE
+
+        if user_group == GroupMemberRole.Maintainer:
+            return Permission.DELETE
+
+        if user_group == GroupMemberRole.Developer:
+            return Permission.WRITE
+
+        return Permission.READ