Skip to content

Commit cec178b

Browse files
AK-47AK-47
authored andcommitted
Avoid unnecessary conversion before comparison.
1 parent 30d0f10 commit cec178b

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

datetime.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -231,12 +231,9 @@ void MXDateTime::on_comboTimeZone_currentIndexChanged(int index)
231231
// Check IANA-zone id differ
232232
const QByteArray &currentTimeZone = QTimeZone::systemTimeZoneId();
233233
const QByteArray &selectedTimeZone = QTimeZone(comboTimeZone->itemData(index).toByteArray()).id();
234-
if (QLatin1String(currentTimeZone) != QLatin1String(selectedTimeZone)) {
235-
zoneIdChanged = true;
236-
} else {
237-
zoneIdChanged = false;
238-
}
239-
update(); // Make the change immediately visible
234+
zoneIdChanged = (currentTimeZone != selectedTimeZone);
235+
// Make the change immediately visible
236+
update();
240237
}
241238
void MXDateTime::on_calendar_selectionChanged()
242239
{

0 commit comments

Comments
 (0)