From 67d7fa1a8bdfc4e281ec6fea4f53db8a7e92097a Mon Sep 17 00:00:00 2001 From: Baraa Abdulrahman Date: Fri, 22 Aug 2025 21:55:11 +0300 Subject: [PATCH 1/2] refactor: update spacing in TopAppBar and background in SeriesDetailsScreen Increased horizontal spacing for icons in TopAppBar. Added background color to the bottom aligned element in SeriesDetailsScreen. --- .../main/java/com/madrid/designSystem/component/TopAppBar.kt | 2 +- .../screens/detailsScreen/seriesDetails/SeriesDetailsScreen.kt | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/designSystem/src/main/java/com/madrid/designSystem/component/TopAppBar.kt b/designSystem/src/main/java/com/madrid/designSystem/component/TopAppBar.kt index 864bb33b6..3523e0067 100644 --- a/designSystem/src/main/java/com/madrid/designSystem/component/TopAppBar.kt +++ b/designSystem/src/main/java/com/madrid/designSystem/component/TopAppBar.kt @@ -67,7 +67,7 @@ fun TopAppBar( Row( modifier = Modifier.padding(end = 16.dp), verticalAlignment = Alignment.CenterVertically, - horizontalArrangement = Arrangement.spacedBy(8.dp) + horizontalArrangement = Arrangement.spacedBy(18.dp) ) { secondIcon?.let { iconRes -> MovioIcon( diff --git a/presentation/src/main/java/com/madrid/presentation/screens/detailsScreen/seriesDetails/SeriesDetailsScreen.kt b/presentation/src/main/java/com/madrid/presentation/screens/detailsScreen/seriesDetails/SeriesDetailsScreen.kt index 180628eea..8492d087d 100644 --- a/presentation/src/main/java/com/madrid/presentation/screens/detailsScreen/seriesDetails/SeriesDetailsScreen.kt +++ b/presentation/src/main/java/com/madrid/presentation/screens/detailsScreen/seriesDetails/SeriesDetailsScreen.kt @@ -342,6 +342,8 @@ private fun SeriesDetailsScreenContent( modifier = Modifier .padding(16.dp) .align(Alignment.BottomCenter) + .background(Theme.color.surfaces.surfaceContainer) + ) } } From 12738dc2535873522fbb2ec77ce53b7c2004c9a5 Mon Sep 17 00:00:00 2001 From: Baraa Abdulrahman Date: Sat, 23 Aug 2025 03:20:57 +0300 Subject: [PATCH 2/2] fix: SnackBar background color and alignment --- .../designSystem/component/MovioSnakBar.kt | 2 +- .../seriesDetails/SeriesDetailsScreen.kt | 24 +++++++++---------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/designSystem/src/main/java/com/madrid/designSystem/component/MovioSnakBar.kt b/designSystem/src/main/java/com/madrid/designSystem/component/MovioSnakBar.kt index 5153f057d..f3e9bc923 100644 --- a/designSystem/src/main/java/com/madrid/designSystem/component/MovioSnakBar.kt +++ b/designSystem/src/main/java/com/madrid/designSystem/component/MovioSnakBar.kt @@ -45,7 +45,7 @@ fun MovioSnakBar( .padding(16.dp) .height(48.dp) .background( - color = Theme.color.surfaces.onSurfaceContainer.copy(0.1f), + color = Theme.color.surfaces.surfaceContainer, shape = RoundedCornerShape(8.dp) ) .padding(horizontal = 16.dp, vertical = 12.dp), diff --git a/presentation/src/main/java/com/madrid/presentation/screens/detailsScreen/seriesDetails/SeriesDetailsScreen.kt b/presentation/src/main/java/com/madrid/presentation/screens/detailsScreen/seriesDetails/SeriesDetailsScreen.kt index 68ae6bf2d..b422a7b57 100644 --- a/presentation/src/main/java/com/madrid/presentation/screens/detailsScreen/seriesDetails/SeriesDetailsScreen.kt +++ b/presentation/src/main/java/com/madrid/presentation/screens/detailsScreen/seriesDetails/SeriesDetailsScreen.kt @@ -359,18 +359,18 @@ private fun SeriesDetailsScreenContent( onSecondIconClick = { listener.onShareIconClick() }, onThirdIconClick = { listener.onFavoriteClick(uiState.seriesId) }, isFavorite = uiState.isFavourite - )if (uiState.showSnackBar) { - Box(modifier = Modifier.fillMaxSize()) { - MovioSnakBar( - message = stringResource(uiState.errorResMessageId), - duration = ToastDuration.SHORT, - onDismiss = { listener.onDismissSnackBar() }, - modifier = Modifier - .padding(16.dp) - .align(Alignment.BottomCenter) - .background(Theme.color.surfaces.surfaceContainer) - - )} + ) + if (uiState.showSnackBar) { + Box(modifier = Modifier + .fillMaxSize()) { + MovioSnakBar( + message = stringResource(uiState.errorResMessageId), + duration = ToastDuration.SHORT, + onDismiss = { listener.onDismissSnackBar() }, + modifier = Modifier + .align(Alignment.BottomCenter) + ) + } } } } \ No newline at end of file