Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove LowRankApprox dependencies #222

Merged
merged 8 commits into from
Jan 31, 2025
Merged

remove LowRankApprox dependencies #222

merged 8 commits into from
Jan 31, 2025

Conversation

aTrotier
Copy link
Contributor

@aTrotier aTrotier commented Jan 6, 2025

No description provided.

@aTrotier aTrotier mentioned this pull request Jan 6, 2025
@aTrotier
Copy link
Contributor Author

aTrotier commented Jan 6, 2025

the error seems related to the release of NIfTI.jl v0.6.1 @Tokazama

@tknopp the package ImageUtils: makeAxisArray expects a vector of Float and now pixelspacing = voxel_size(ni.header) returns a Tuple{Float32}

@aTrotier
Copy link
Contributor Author

aTrotier commented Jan 6, 2025

failing tests should be fixed by : tknopp/ImageUtils.jl#20

@Tokazama
Copy link

Tokazama commented Jan 6, 2025

I'm pretty sure voxel_size has always returned a tuple as well as ImageCore.pixelspacing.

@aTrotier
Copy link
Contributor Author

aTrotier commented Jan 8, 2025

Weird, but the fix : tknopp/ImageUtils.jl#20 seems to fix it.

@Tokazama
Copy link

Tokazama commented Jan 8, 2025

Weird, but the fix : tknopp/ImageUtils.jl#20 seems to fix it.

Interesting. One thing I haven't considered yet is adding a Unitful extension to NIfTI. I'll have to think over how to do this without disturbing everyone's workflow.

@aTrotier
Copy link
Contributor Author

@aTrotier aTrotier merged commit 9c97e76 into master Jan 31, 2025
2 of 15 checks passed
@aTrotier aTrotier deleted the delete_LowRankApprox branch January 31, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants