Skip to content

Conversation

@mreho
Copy link

@mreho mreho commented Jul 14, 2025

When using hostPort, the ManageSieve port was not actually exposed — I believe this was simply forgotten in the template.

The second issue is that Proxy Protocol and publicly exposed ports do not necessarily require a Service. When using hostPort and deploying via DaemonSet, front.externalService can be disabled. I had to edit _helpers.tpl to account for this. The advantage of not using an externalService with an upstream Ingress Controller is that it avoids an unnecessary proxy layer.

The third issue occurs when using Proxy Protocol: by default, the chart outputs an error stating that ingress.realIpHeader should not have any value. However, with Proxy Protocol (which is likely the most common case when proxying TCP traffic), this field must indeed be left empty.

Additionally, I moved values that did not belong under ingress. to front..
These are breaking changes.

@mreho
Copy link
Author

mreho commented Jul 15, 2025

Just to add some screenshots of my current working setup :

Capture d’écran du 2025-07-15 10-09-52 Capture d’écran du 2025-07-15 10-10-22 Capture d’écran du 2025-07-15 10-41-21

@fastlorenzo fastlorenzo requested a review from Copilot August 21, 2025 22:16
@fastlorenzo fastlorenzo added the needs testing Issues or pull requests that need testing label Aug 21, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the Helm chart configuration for Mailu by addressing three key issues: missing hostPort exposure for ManageSieve, unnecessary coupling between Proxy Protocol and external services, and incorrect validation logic for Proxy Protocol configuration.

Key changes:

  • Added hostPort exposure for ManageSieve (port 4190) when hostPort is enabled
  • Moved proxy protocol and TLS configuration from ingress.* to front.* namespace
  • Fixed proxy protocol validation to allow empty realIpHeader when using Proxy Protocol

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
utils/check_env_vars.py Updated TLS_FLAVOR environment variable mapping from ingress to front namespace
charts/mailu/values.yaml Moved proxy protocol, realIpHeader, realIpFrom, and tlsFlavorOverride settings from ingress to front section
charts/mailu/templates/front/deployment.yaml Added hostPort 4190 for ManageSieve when hostPort is enabled and fixed port formatting
charts/mailu/templates/envvars-configmap.yaml Updated environment variable references to use front namespace instead of ingress
charts/mailu/templates/_services.tpl Removed dependency on externalService for proxy protocol configuration and updated validation logic
charts/mailu/templates/_helpers.tpl Updated TLS flavor helper to reference front namespace and fixed deprecated value detection
charts/mailu/README.md Updated documentation to reflect the configuration namespace changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

enabled: true

## @param front.realIpHeader Sets the value of `REAL_IP_HEADER` environment variable in the `front` pod
realIpHeader: ""
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment on line 665 states 'Enabling any of these requires to have ingress.realIpFrom set' but should be updated to reference 'front.realIpFrom' since the configuration has been moved to the front namespace.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale Issues or pull requests that have not been updated for a while label Sep 28, 2025
@mreho
Copy link
Author

mreho commented Sep 28, 2025

Bump

@github-actions github-actions bot removed the Stale Issues or pull requests that have not been updated for a while label Sep 30, 2025
@github-actions
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale Issues or pull requests that have not been updated for a while label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs testing Issues or pull requests that need testing Stale Issues or pull requests that have not been updated for a while

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants