Skip to content

Commit c0d0821

Browse files
Update pr
1 parent 58ad236 commit c0d0821

File tree

4 files changed

+23
-7
lines changed

4 files changed

+23
-7
lines changed

app/controllers/vm_common.rb

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,13 @@ def snap_pressed
299299
@center_toolbar = 'x_vm_snapshot'
300300
@explorer = true
301301
formatted_time = format_timezone(@snap_selected[:create_time].to_time, Time.zone, "view")
302-
render :json => {:data => {:data => @snap_selected, :time => formatted_time}}, :status => 200
302+
number_to_human_size(@snap_selected[:total_size], :precision => 2)
303+
if @snap_selected[:total_size] == nil || @snap_selected[:total_size] == 0
304+
formatted_size = ''
305+
else
306+
formatted_size = _("%{number} bytes") % {:number => number_with_delimiter(@snap_selected[:total_size], :delimiter => ",", :separator => ".")}
307+
end
308+
render :json => {:data => {:data => @snap_selected, :size => formatted_size, :time => formatted_time}}, :status => 200
303309
# render :update do |page|
304310
# page << javascript_prologue
305311
# page << javascript_reload_toolbars

app/javascript/components/vm-snapshot-tree-select/index.jsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@ import PropTypes from 'prop-types';
33
import './styles.css';
44
import SnapshotTree from './snapshot-tree';
55

6-
const VMSnapshotTreeSelect = ({ tree, selected, time }) => {
7-
// const [{ initialValues, isLoading }, setState] = useState({});
8-
const [snapshot, setSnapshot] = useState({ ...selected, time });
6+
const VMSnapshotTreeSelect = ({
7+
tree, selected, size, time,
8+
}) => {
9+
const [snapshot, setSnapshot] = useState({ ...selected, size, time });
910

1011
// eslint-disable-next-line react/prop-types
1112
return (
@@ -20,7 +21,7 @@ const VMSnapshotTreeSelect = ({ tree, selected, time }) => {
2021
</p>
2122
</div>
2223
<div className="snapshot-detail-value">
23-
{snapshot.description || ''}
24+
{snapshot.data ? snapshot.data.description : snapshot.description || ''}
2425
</div>
2526
</div>
2627
<div className="snapshot-details">
@@ -56,11 +57,13 @@ const VMSnapshotTreeSelect = ({ tree, selected, time }) => {
5657
VMSnapshotTreeSelect.propTypes = {
5758
tree: PropTypes.objectOf(PropTypes.any).isRequired,
5859
selected: PropTypes.objectOf(PropTypes.any),
60+
size: PropTypes.string,
5961
time: PropTypes.string,
6062
};
6163

6264
VMSnapshotTreeSelect.defaultProps = {
6365
selected: {},
66+
size: '',
6467
time: '',
6568
};
6669

app/javascript/components/vm-snapshot-tree-select/snapshot-tree.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ const convertData = (node) => {
7373
};
7474

7575
const SnapshotTree = ({ nodes, setSnapshot }) => {
76-
console.log(nodes);
7776
const [selectedNode, setSelectedNode] = useState('');
7877

7978
const data = {
@@ -109,6 +108,7 @@ const SnapshotTree = ({ nodes, setSnapshot }) => {
109108
http.post(`/${ManageIQ.controller}/snap_pressed/${encodeURIComponent(shortId)}`).then((response) => {
110109
if (response.data) {
111110
const tempData = response.data;
111+
tempData.size = response.data.size;
112112
tempData.time = response.data.time;
113113
setSnapshot(tempData);
114114
}

app/views/vm_common/_snapshots_desc.html.haml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,14 @@
44
- unless session[:snap_selected].nil?
55
- selected_id = Snapshot.find(session[:snap_selected])
66

7-
= react('VmSnapshotTreeSelect', {tree: @snapshot_tree, selected: selected_id, time: format_timezone(selected_id[:create_time].to_time, Time.zone, "view")})
7+
- time = format_timezone(selected_id[:create_time].to_time, Time.zone, "view")
8+
- if selected_id[:total_size] == nil || selected_id[:total_size] == 0
9+
- size = ''
10+
- else
11+
= number_to_human_size(selected_id[:total_size], :precision => 2)
12+
- size = _("%{number} bytes") % {:number => number_with_delimiter(selected_id[:total_size], :delimiter => ",", :separator => ".")}
13+
14+
= react('VmSnapshotTreeSelect', {tree: @snapshot_tree, selected: selected_id, size: size, time: time})
815

916
#desc_content.desc_content
1017
- if session[:snap_selected].present? || @record.snapshots.count > 0

0 commit comments

Comments
 (0)